Skip to content

Conversation

@okumin
Copy link

@okumin okumin commented Feb 11, 2025

You can see some discussions in #6.

This is the diff between the definition of Apache Hive and our new definition. The new definition doesn't support Table get_table(1:string dbname, 2:string tbl_name), so we have to drop the support of Hive 2.2. We can add it back if we want to keep the compatibility.

% diff ../hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift src/main/thrift
1,3c1
< #!/usr/local/bin/thrift -java
< 
< /**
---
> /*
20,23d17
< 
< #
< # Thrift Service that the MetaStore is built on
< #
25,29c19
< include "share/fb303/if/fb303.thrift"
< 
< namespace java org.apache.hadoop.hive.metastore.api
< namespace php metastore
< namespace cpp Apache.Hadoop.Hive
---
> namespace java io.trino.hive.thrift.metastore
2573c2563
< service ThriftHiveMetastore extends fb303.FacebookService
---
> service ThriftHiveMetastore

@cla-bot cla-bot bot added the cla-signed label Feb 11, 2025

TARGET=/build/target/generated-sources/thrift
GRADLE_VERSION=8.4
THRIFT_VERSION=$(mvn -q help:evaluate -Dexpression=libthrift.version -DforceStdout)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to upgrade it because Trino uses 0.21.0.

@ebyhr
Copy link
Member

ebyhr commented Feb 13, 2025

cc: @electrum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants