Skip to content

Conversation

@0x0elliot
Copy link

@0x0elliot 0x0elliot commented Oct 5, 2023

Closes #554

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  • Verified the SDK change
  • Verified the API change

Changelog

Added in the requested features.


Screenshots

Screenshot 2023-10-05 at 7 21 15 AM Screenshot 2023-10-05 at 7 21 31 AM

💯

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: d87492f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0x0elliot
Copy link
Author

0x0elliot commented Oct 5, 2023

draft because i need to do some testing before i give thumbs up

@0x0elliot 0x0elliot marked this pull request as ready for review October 5, 2023 01:24
@0x0elliot
Copy link
Author

0x0elliot commented Oct 5, 2023

saw a bug in the SDK. let me fix that before the review.

@0x0elliot
Copy link
Author

should be good now!

@ericallam
Copy link
Member

Thanks @0x0elliot for your attempt! There is another PR open for this feature as well #562 that is a little closer to what we were looking for. You can either:

@0x0elliot 0x0elliot closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1363] feat: Allow cancelling job runs from the TriggerClient

2 participants