-
-
Notifications
You must be signed in to change notification settings - Fork 939
[TRI-1333] : Upgrade all packages/* and use fetch instead of node-fetch #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@matt-aitken Please review and suggest changes, if any. Thanks |
|
Have you run and tested the code still works? The easiest way to do that is to run jobs in https://github.com/triggerdotdev/trigger.dev/blob/main/references/job-catalog/README.md |
|
Hello @ericallam, So, I need to run all jobs
Please let me know if it's the right way. Thanks. |
|
No definitely don't run them all haha, I would just pick a few to run as a smoke test. The simplest is probably |
|
Great, I will 3-4 files in the src and then update with the screenshots here. |
|
Yea considering the change, seeing successful runs should be a good enough test. And since this is a client only change, you don't even have to run the server locally if you don't want to, you could just use cloud.trigger.dev |
|
Perfect, I will update the screenshots asap. |
|
@ericallam I have performed the tests and updated the test results in the comments above. Please review and let me know if it looks good. Thanks. |
ericallam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also make sure to run pnpm run typecheck in the root of the repo to make sure all the types still are valid.
packages/trigger-sdk/package.json
Outdated
| }, | ||
| "engines": { | ||
| "node": ">=16.8.0" | ||
| "node": "^18.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This limits the Node version to >= 18 and < 19, which isn't what we want. I'd just do >=18.0.0
Closes #525
✅ Checklist
Testing
Type checking has been done and no errors are found.
pnpm run --filter "./packages/**" typecheckSmoke Testing has been done as suggested by @ericallam .
Jobs were also run successfully on the Trigger.dev cloud dashboard.
Changelog
pnpm.Node-Fetchimports and dependency are removed in all packages andfetchis getting used as the native function as supported by Node 18 now.Screenshots
List of all modeified files are as follows.