Skip to content

Conversation

@hmacr
Copy link
Contributor

@hmacr hmacr commented Oct 3, 2023

Closes #484

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  • Verified that the update command accepts the version and uses it for dependency update.
  • Verified that the updated command falls back to latest if the version is not provided.

Changelog

  • Allows CLI users to provide a version for trigger-dev package update.

💯

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

🦋 Changeset detected

Latest commit: 1cc41b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@trigger.dev/cli Patch
astro-example Patch
@references/job-catalog Patch
@references/nextjs Patch
@references/package-tester Patch
perf Patch
@trigger.dev/tailwind-config Patch
@trigger.dev/tsconfig Patch
@trigger.dev/astro Patch
@trigger.dev/core Patch
@trigger.dev/eslint-plugin Patch
@trigger.dev/express Patch
@trigger.dev/integration-kit Patch
@trigger.dev/nextjs Patch
@trigger.dev/react Patch
@trigger.dev/remix Patch
@trigger.dev/testing Patch
@trigger.dev/sdk Patch
@trigger.dev/airtable Patch
@trigger.dev/github Patch
@trigger.dev/linear Patch
@trigger.dev/openai Patch
@trigger.dev/plain Patch
@trigger.dev/resend Patch
@trigger.dev/sendgrid Patch
@trigger.dev/slack Patch
@trigger.dev/stripe Patch
@trigger.dev/supabase Patch
@trigger.dev/typeform Patch
@references/unit-testing Patch
@references/remix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

newPackageJSON[tmp.type][packageName] = updatedDependencies[packageName];
}
});
console.log(newPackageJSON);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this console.log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, missed it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@ericallam ericallam merged commit c070e78 into triggerdotdev:main Oct 9, 2023
arjunindia pushed a commit to arjunindia/trigger.dev that referenced this pull request Oct 10, 2023
…riggerdotdev#536)

* feat: allow CLI update to accept a version for trigger-dev package

* remove console log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1281] feat: Add an optional to param to @trigger.dev/cli init update

2 participants