Feat/svelte kit support #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
9 tasks
Member
|
@Chigala I made some changes to the Remix PR before merging it.
Can you make sure that these aren't issues in this PR? I'll continue looking at new framework PRs tomorrow. |
- commented out the useEventRunDetails
matt-aitken
added a commit
that referenced
this pull request
Oct 6, 2023
* Feat/svelte kit support (#467) * feat: implemented svelte-kit adapter * feat: implemented the @trigger.dev/svelte package * scaffolded a sveltekit example project with trigger.dev * added the convertToStandardRequest function in the sveltekit package * example sveltekit project with the @trigger.dev/svelte package * doc: added the manual setup guide for sveltekit * updated the web app onboard for sveltekit * formatted the manual setup guide for sveltekit * added a link to webapp sveltekit onboarding * added a wait function to the sveltekit example app job * typo fix * removed comments from the @trigger.dev/svelte - commented out the useEventRunDetails * updated package.json to use internal packages * added a .env.example file * updated the example-svelte-app * updated the svelte-example * updated the onboarding page to reflect requested changes * made the manual setup guide more specific * created a .env.example file for svelte-example * added import aliases * updated the tsconfig and svelte.config file * updated to use uint8Array * added missing paths in the tsconfig --------- Co-authored-by: Matt Aitken <[email protected]> * Moved examples to references * Tweaked the SveleteKit manual setup guide * Updated zod, and set the svelte/sveltekit package versions to match other packages * Added the headers to the response from the SvelteKit api/trigger route * Changeset for Svelte and SvelteKit packages * Revert change to rawBody * Remove core from changeset packages * Delete svelte .npmrc file * Build svelte package to build, not build/lib * Made the snapshot instructions easier to copy * Delete the svelte package * Latest lockfile * Updated the SvelteKit docs * Attempt to get Svelte to import the package * Updates for port and host options * Updated lockfile from main * Update neat-feet-wait.md --------- Co-authored-by: Chigala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 1 - Sveltekit Adapter
sveltekit.examples/sveltekit-examplefolder.Task 2 - Add a README.md file
README.mdfile inside thepackages/sveltekitfolder.Task 3 - Write the documentation
manual-setup-sveltekit.mdxfile in/docs/_snippets/.client-adaptors.mdxpage with the Sveltekit framework.Task 4 - Update the webapp onboarding
route.tsxpage located in_app.orgs.$organizationSlug.projects.$projectParam.setup.sveltekit, replaced the<FrameworkComingSoon/>component with new onboarding steps.FrameworkSelector.tsxfile, add "supported" to the framework you’ve worked on.I didn't include trigger init CLI support for the framework because I don't know what the Trigger team has in mind concerning how to handle initialization for the other separate frameworks. If this is needed I don't mind implementing it. I'll also love your feedback on this!
/claim #453
/closes #453