Skip to content

Workaround failing build_unix_debug #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Sep 20, 2022

Something needs the symbol even though we don't do unwinding (I think):

/bin/ld: build/unix/rust/debug/libtrezor_lib.a(core-05898138a596088a.core.4cbccd39-cgu.0.rcgu.o):(.data.DW.ref.rust_eh_personality[DW.ref.rust_eh_personality]+0x0): undefined reference to `rust_eh_personality'

Defining one that does nothing seems to avoid the problem, not sure what happens when it actually gets called. Needs nightly rustc. Possibly related: rust-lang/rust#56152, https://docs.rust-embedded.org/embedonomicon/smallest-no-std.html#eh_personality

@mmilata mmilata requested a review from prusnak as a code owner September 20, 2022 08:59
@mmilata mmilata requested review from jpochyla and matejcik and removed request for prusnak September 20, 2022 08:59
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK?? 🤷‍♀️ @jpochyla any opinion?

@matejcik matejcik merged commit f956966 into master Oct 21, 2022
@matejcik matejcik deleted the mmilata/eh-personality branch October 21, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants