-
Notifications
You must be signed in to change notification settings - Fork 79
Use pyproject.toml with hatch #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 91.39% 97.27% +5.87%
==========================================
Files 34 16 -18
Lines 2465 1507 -958
Branches 0 212 +212
==========================================
- Hits 2253 1466 -787
+ Misses 212 27 -185
- Partials 0 14 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I modified a bit the Github action so instead of calling hatch once to run all the tests, the workflow creates a matrix of python and seaborn versions (we could also add an OS matrix if needed, see https://github.com/platformdirs/platformdirs/ for the modifications to do). Github runs matrix jobs in parallel so the tests are substantially faster. |
|
I forgot to mention that python 3.7 is not tested (hatch was not working for me with this python version). It would be better to drop it, as it is EOL anyway. |
21f2da1 to
9f525e2
Compare
|
Thanks for merging #155, I rebased this PR, all tests are passing now. I will check the jupyter notebook. Reminder: minimal python version is set to 3.8 |
|
The notebook runs correctly with python 3.12. I added support for python 3.13 (only compatible with seaborn 0.13), the tests are passing. |
|
Coverage is working now! |
|
@trevismd it's ready for review |
|
closes #150 I moved all the source files to a Also I added some linting scripts: |
use hatch environments add test_script to test plotting figures
# This is the 1st commit message: do not move to src # The commit message #2 will be skipped: # do not move to src
|
Hi @trevismd , The next step would be to add type annotations and a fast linter ( A reverted moving the source to a |
|
I think it would make sense to merge this PR, and then as a next step work to improve docstrings and type annotations to make the package and documentation a bit more accessible? |
Modernize the building and testing framework:
add test_script to test plotting figures-> added in Compatibility with seaborn 0.13 #155To build:
hatch buildorpython -m buildTo bump version:
hatch version minorTo test:
hatch run tests:runTo test with coverage:
hatch run tests:run-cov && hatch run coverage:runTo build and test docs:
hatch run docs:allTo run examples:
hatch run examples:run -- --plot_type=boxplot --data_type=df_with_group_and_hueTo test #155 I had to write the
test_script.pyfile and it was very convenient to usehatchenvironments for testing. So I thought I should actually make a PR about it :)