lib: support spaces in field key search #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #277
Honestly, I don't fully understand this issue. The way the code was written, it should already support both field keys and values containing spaces. But during testing, I noticed something weird. The example Smart Node I made for testing used the following search:
"travel by":carAccording to a console log,
fieldQuerycontained the object:{"travel by": "car"}During the
for (const f in fieldQuery)loop,fis a string that contained escaped quotes. (example:"\"travel by\""). The keys infieldsdidn't. I'm not sure why that's happening, but this change fixes it.I'll put this out for review, but I'll continue investigating to better understand what's going on.