Skip to content

Fix deprecation notice about implicit cast of floats. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Fix deprecation notice about implicit cast of floats. #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c04737
Fix deprecation notice about implicit cast of floats.
chrisryan Feb 17, 2023
f5f2c6e
Add Php 8.2 to build.
chrisryan Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-18.04
strategy:
matrix:
php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1']
php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
3 changes: 1 addition & 2 deletions src/AbstractQueue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,9 +408,8 @@ private function throwIfTrue(
}
}

private function calculateEndTime(int $waitDurationInMillis) : int
private function calculateEndTime(int $waitDurationInMillis) : float
{
//ints overflow to floats, should be fine
return microtime(true) + ($waitDurationInMillis / 1000.0);
}
}