Fix: accept hyphens in generative section names #1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyagdit
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
requested changes
Aug 6, 2020
gaborbernat
approved these changes
Aug 7, 2020
|
Yay! Thanks @Tyagdit and @gaborbernat 🎉 |
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generative section names wouldn't work if there were hyphens within the braces. the regex caused everything after the hyphen to be omitted resulting in not being able to use empty factors like
[testenv:foo{,-factor}]and forcing users to put the hyphens outside the braces.Fixes #1636
Contribution checklist:
CONTRIBUTORS(preserving alphabetical order)