Allow omitting default values #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please never put an issue number into the description of a PR. Just put the change description the PR introduces. |
gaborbernat
requested changes
Aug 8, 2022
| .. sphinx_argparse_cli:: | ||
| :module: parser | ||
| :func: main | ||
| :no_default_values: false |
Member
There was a problem hiding this comment.
What's with the double negative here? Either make this not take an argument or drop the no prefix.
Member
There was a problem hiding this comment.
Also, add a changelog entry.
Contributor
Author
|
I made the changes as requested in the above comment. I hope it is OK to introduce a new version number in the change log. Sorry for the error in the test input file. |
gaborbernat
requested changes
Aug 9, 2022
CHANGELOG.md
Outdated
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| ## 1.9.1 |
Member
There was a problem hiding this comment.
This is a feature so should be 1.10.0 per semver rules.
Contributor
Author
|
Thank you for your review. I changed the version number in CHANGELOG.md. |
gaborbernat
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added option
no_default_valueswith test as suggested in issue #55.