Use the correct iframe width with resize buttons. Fix #226 #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the iframe has a `box-sizing: border-box;` inherited from https://github.com/torchbox/django-pattern-library/blob/main/pattern_library/static/pattern_library/src/scss/abstracts/_base.scss the width is being affected by the border that is being applied here, and it could be affected by other properties (like padding)
thibaudcolas
approved these changes
Aug 18, 2023
Member
thibaudcolas
left a comment
thibaudcolas
left a comment
There was a problem hiding this comment.
Nice one @jkevingutierrez! I’m surprised we didn’t notice this before 😄 Very elegant solution.
thibaudcolas
approved these changes
Aug 18, 2023
Member
thibaudcolas
left a comment
thibaudcolas
left a comment
There was a problem hiding this comment.
Nice one @jkevingutierrez! I’m surprised we didn’t notice this before 😄 Very elegant solution.
thibaudcolas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the iframe has a
box-sizing: border-box;inherited from _base.scss the width is being affected by the border that is being applied here (reducing the real width in 2px).Also, it is prune to other errors, as other properties could affect that width (like adding a padding)
Fixes #226
Checklist