Sync up with dev #26
Sync up with dev #26
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| totalPages: Math.ceil(totalCount / perPage), | ||
| }, | ||
| }; | ||
| return reviewTypes as ReviewTypeResponseDto[]; |
There was a problem hiding this comment.
The removal of the meta object from the return statement changes the structure of the response. If the meta information is required by the client or other parts of the application, consider whether this change might break existing functionality or if additional adjustments are needed elsewhere in the codebase to accommodate this change.
| @@ -45,7 +45,7 @@ import { | |||
| ArtifactsListResponseDto, | |||
| } from 'src/dto/artifacts.dto'; | |||
| import { LoggerService } from '../../shared/modules/global/logger.service'; | |||
| import { PaginatedResponse, PaginationDto } from '../../dto/pagination.dto'; | |||
| import { PaginationDto } from '../../dto/pagination.dto'; | |||
There was a problem hiding this comment.
The PaginatedResponse import has been removed. Ensure that this type is no longer used in the code. If it is still needed, it should be re-imported.
| @@ -166,11 +167,16 @@ export class SubmissionController { | |||
| @Query() queryDto: SubmissionQueryDto, | |||
| @Query() paginationDto?: PaginationDto, | |||
| @Query() sortDto?: SortDto, | |||
| ): Promise<PaginatedResponse<SubmissionResponseDto>> { | |||
| ): Promise<SubmissionResponseDto[]> { | |||
There was a problem hiding this comment.
The return type of the function has been changed from Promise<PaginatedResponse<SubmissionResponseDto>> to Promise<SubmissionResponseDto[]>. Ensure that this change is intentional and that all parts of the codebase that depend on this method are updated accordingly to handle the new return type.
| paginationDto, | ||
| sortDto, | ||
| ); | ||
| return paginatedData.data; |
There was a problem hiding this comment.
The method now returns paginatedData.data. Verify that paginatedData.data is always an array of SubmissionResponseDto and that it handles cases where paginatedData.data might be undefined or null.
No description provided.