Fix for completed dates in Topgear houlrly report #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ON tl.challenge_id = bc.id | ||
| LEFT JOIN group_list gl | ||
| ON gl.challenge_id = bc.id | ||
| LEFT JOIN LATERAL ( |
There was a problem hiding this comment.
[correctness]
The new lateral join for latest_actual_end_date uses MAX(cp."actualEndDate") without any additional filtering or ordering. Ensure that actualEndDate is always populated correctly and that using MAX will consistently yield the correct completed_date. Consider if additional criteria are needed to ensure the correct phase is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported via Slack