-
Notifications
You must be signed in to change notification settings - Fork 21
PM-1904 active challenges page #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,3 +79,7 @@ | |
| background-color: $red-25; | ||
| color: $red-140; | ||
| } | ||
|
|
||
| .mr2 { | ||
| margin-right: $sp-2; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ import { | |
| } from '../../models' | ||
| import { TableWrapper } from '../TableWrapper' | ||
| import { ProgressBar } from '../ProgressBar' | ||
| import { IconAiReview, phasesIcons } from '../../assets/icons' | ||
|
|
||
| import styles from './TableActiveReviews.module.scss' | ||
|
|
||
|
|
@@ -253,11 +254,20 @@ export const TableActiveReviews: FC<Props> = (props: Props) => { | |
| isSortable: true, | ||
| label: 'Phase', | ||
| propertyName: 'currentPhase', | ||
| renderer: (data: ActiveReviewAssignment) => ( | ||
| <div className={styles.phase}> | ||
| {data.currentPhase} | ||
| </div> | ||
| ), | ||
| renderer: (data: ActiveReviewAssignment) => { | ||
| const Icon = data.hasAIReview ? IconAiReview : ( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [❗❗ |
||
| phasesIcons[data.currentPhase.toLowerCase() as keyof typeof phasesIcons] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [ |
||
| ) | ||
|
|
||
| return ( | ||
| <div className={styles.phase}> | ||
| {Icon && ( | ||
| <Icon className={styles.mr2} /> | ||
| )} | ||
| {data.currentPhase} | ||
| </div> | ||
| ) | ||
| }, | ||
| type: 'element', | ||
| }, | ||
| { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -141,6 +141,7 @@ export const transformAssignments = ( | |
| .local() | ||
| .format(TABLE_DATE_FORMAT) | ||
| : undefined, | ||
| hasAIReview: base.hasAIReview, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [❗❗ |
||
| id: base.challengeId, | ||
| index: currentIndex, | ||
| name: base.challengeName, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ export interface ActiveReviewAssignment { | |
| currentPhaseEndDateString?: string | ||
| challengeEndDate?: string | Date | null | ||
| challengeEndDateString?: string | ||
| hasAIReview: boolean; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [❗❗ |
||
| timeLeft?: string | ||
| timeLeftColor?: string | ||
| timeLeftStatus?: string | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,4 +35,7 @@ | |
| .icon { | ||
| flex: 0 0; | ||
| margin-right: $sp-2; | ||
| > svg path { | ||
| fill: $tc-white; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,11 @@ const NotificationBanner: FC<NotificationBannerProps> = props => { | |
| return ( | ||
| <div className={styles.wrap}> | ||
| <div className={styles.inner}> | ||
| {props.icon || ( | ||
| <div className={styles.icon}> | ||
| <div className={styles.icon}> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [ |
||
| {props.icon || ( | ||
| <InformationCircleIcon className='icon-xl' /> | ||
| </div> | ||
| )} | ||
| )} | ||
| </div> | ||
|
|
||
| {props.content} | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[⚠️
maintainability]The key
'iterative review'and'review'both map toIconReview. If these represent distinct phases, consider using different icons or clarifying the distinction to avoid confusion.