Skip to content

PM-1612 Fix Applications tab view #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

PM-1612 Fix Applications tab view #1213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,8 @@ const CopilotOpportunityDetails: FC<{}> = () => {
const [activeTab, setActiveTab]: [string, Dispatch<SetStateAction<string>>] = useState<string>(activeTabHash)

useEffect(() => {
if (isAdminOrPM) {
setActiveTab(activeTabHash)
} else {
setActiveTab('0')
}
}, [activeTabHash, isAdminOrPM])
setActiveTab(activeTabHash)
}, [activeTabHash])

const handleTabChange = useCallback((tabId: string): void => {
setActiveTab(tabId)
Expand Down Expand Up @@ -286,7 +282,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {
<TabsNavbar
defaultActive={activeTab}
onChange={handleTabChange}
tabs={getCopilotDetailsTabsConfig(isAdminOrPM, copilotApplications?.length || 0)}
tabs={getCopilotDetailsTabsConfig(copilotApplications?.length || 0)}
/>
)
}
Expand All @@ -297,7 +293,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {
opportunity={opportunity}
members={members}
onApplied={onApplied}
isAdminOrPM
isAdminOrPM={isAdminOrPM}
/>
)}

Expand Down
7 changes: 1 addition & 6 deletions ...copilots/src/pages/copilot-opportunity-details/tabs/config/copilot-details-tabs-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export enum CopilotDetailsTabViews {
applications = '1',
}

export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean, count: number): TabsNavItem[] => (isAdminOrPM ? [
export const getCopilotDetailsTabsConfig = (count: number): TabsNavItem[] => ([
{
id: CopilotDetailsTabViews.details,
title: 'Details',
Expand All @@ -18,11 +18,6 @@ export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean, count: number)
id: CopilotDetailsTabViews.applications,
title: 'Applications',
},
] : [
{
id: CopilotDetailsTabViews.details,
title: 'Details',
},
])

export const CopilotDetailsTabsConfig: TabsNavItem[] = [
Expand Down