Skip to content

fix(PM-1503): Weight column in view scorecard page #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

fix(PM-1503): Weight column in view scorecard page #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...review/src/pages/scorecards/ViewScorecardPage/ScorecardGroups/ScorecardGroups.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
.heading {
.groupInfo {
flex-direction: row;
.weight {
text-align: end;
}
.name {
margin-bottom: 0px;
}
Expand Down
2 changes: 1 addition & 1 deletion src/apps/review/src/pages/scorecards/ViewScorecardPage/ScorecardGroups/ScorecardGroups.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const ScorecardGroups: FC<ScorecardGroupsProps> = (props: ScorecardGroupsProps)
<div className={styles.groupNumber}>{`Group ${index + 1}`}</div>
<div className={styles.groupInfo}>
<div className={styles.name}>{group.name}</div>
<div>{group.weight}</div>
<div className={styles.weight}>{group.weight}</div>
</div>
</div>
<ScorecardSections sections={group.sections} />
Expand Down
8 changes: 7 additions & 1 deletion ...ew/src/pages/scorecards/ViewScorecardPage/ScorecardSections/ScorecardSections.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@
.name {
margin-bottom: 0px;
}
.weight {
text-align: end;
}
}
}
.questions {
Expand All @@ -98,7 +101,10 @@
}
}
.right {
justify-content: flex-start;
justify-content: flex-end;
.weight {
text-align: end;
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...pps/review/src/pages/scorecards/ViewScorecardPage/ScorecardSections/ScorecardSections.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const ScorecardSections: FC<ScorecardSectionsProps> = (props: ScorecardSectionsP
<div>{`Section ${sectionIndex + 1}`}</div>
<div className={styles.sectionInfo}>
<div className={styles.name}>{section.name}</div>
<div>{section.weight}</div>
<div className={styles.weight}>{section.weight}</div>
</div>
</div>
<div className={styles.questions}>
Expand Down Expand Up @@ -55,7 +55,7 @@ const ScorecardSections: FC<ScorecardSectionsProps> = (props: ScorecardSectionsP
</div>
</div>
<div className={styles.right}>
<div>{question.weight}</div>
<div className={styles.weight}>{question.weight}</div>
</div>
</div>
))
Expand Down