This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Feature/add version number #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin/sms authentication
|
This is out of character, but you really and truly rocked this pull request. Great job, Seth! 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add a
VERSIONconstant to the library, making it easier to debug (e.g., "before going any further, what is yourtoopher.VERSION?").I wrote a test to ensure that the version number exists in the library and is greater than or equal to this version,
1.0.6, and wrote another test to ensure that the version number from the library matches the version number in thesetup.pyfile used by PyPy/pip.Note: This PR is against
developbut was branched offmaster. It looks like the fancy demo is onmasterrather thandevelop, which explains why those changes are showing up as well.