chore: remove use of state field in SpanBuilder #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
commented
Sep 25, 2025
bantonsson
force-pushed
the
ban/otel-cleanup
branch
from
0045aa6 to
bde2788
Compare
|
Ah, sorry, I forgot about this during the day but we can still do this in a point release. That said, I'd also like to untangle the dependencies between opentelemtry and us because now we're in a weird state where presumably their appender depends on an older version without the context propagation rework and will continue to until the next breaking release. |
|
No worries. Doing this in a point release is fine. Yes, moving the appenders to https://github.com/open-telemetry/opentelemetry-rust-contrib would be a good thing to break up the circularity. |
mladedav
reviewed
Oct 1, 2025
bantonsson
force-pushed
the
ban/otel-cleanup
branch
from
bde2788 to
c9b8068
Compare
bantonsson
force-pushed
the
ban/otel-cleanup
branch
from
c9b8068 to
a1b2a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The state field will be removed from the public API of the OpenTelemetry
SpanBuilderalong with a number of other fields open-telemetry/opentelemetry-rust#2886This is the last of the removed fields being used.
Solution
Keep the state in the data until the OpenTelemetry
Spanis created.