adding support for setting the status of the span through SpanExt #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have found that when working with
tracingspans created by 3rd party libraries, it is incredibly difficult to set the OpenTelemetry Status of the span, which results in always having an unset span in my visualization tool.In this case, I am working with the span created by the
aws_lambda_runtimecrate.Unfortunately, since the span in the
aws_lambda_runtimecrate does not include theotel.status_codeattribute upfront theOpenTelemetryLayer::SpanAttributeVisitor::record_strandOpenTelemetryLayer::SpanAttributeVisitor::record_debugnever gets triggered when callingtracing::Span::current().record("otel.status_code", "ok");This behavior of therecordfunction ignoring new fields is documented hereSolution
My solution to this is add a new member
OpenTelemetrySpanExt::set_statusthat takes anopentelemetry::trace::Statusenum that gets written to the underlyingSpanBuilder.