Skip to content

Conversation

Woyten
Copy link
Contributor

@Woyten Woyten commented Feb 8, 2019

With trait objects working, we no longer need the fmt Rust module. This PR removes it.
We should also close #19 after merging this.

Copy link
Contributor

@torfmaster torfmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torfmaster torfmaster merged commit 32164f2 into tock:master Feb 8, 2019
@Woyten Woyten deleted the feature/remove-fmt-module branch February 9, 2019 11:51
jrvanwhy pushed a commit to jrvanwhy/tock-on-titan that referenced this pull request Mar 9, 2019
…int.

tock::fmt was removed in tock/libtock-rs#73. I've changed my stance on simple_fmt's future a bit: if we decide we like it, then we should suggest migrating it into libtock-rs. That would prevent the core::fmt formatting code from being necessary at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functions of core::fmt do not work

2 participants