-
Notifications
You must be signed in to change notification settings - Fork 109
fix inconsistency in doc: send_keys #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request fixes an inconsistency in the documentation for the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @subbyte - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great you caught this inconsistency and fixed it!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 37 37
Lines 2430 2430
Branches 368 368
=======================================
Hits 1980 1980
Misses 308 308
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There is a minor doc inconsistency when I read the
send_keys()
method ofpane
. This fixes it.Summary by Sourcery
Documentation:
literal
parameter in thesend_keys()
method of thepane
module from True to False.