Skip to content

Conversation

@Freed-Wu
Copy link
Contributor

No description provided.

@bruno-
Copy link
Member

bruno- commented Aug 22, 2022

The change looks good, but I can definitely see myself looking at this in 3 months and wondering "why do we have this set command here?".

Can you think of a way to briefly document this inline? Maybe a comment above each command? Or maybe:

  • extract the sed .... string in a function called maybe preserve_url_hash
  • document the function
  • Interpolate function output in all 3 places where needed echo "$(preserve_url_hash) ..."

@Freed-Wu
Copy link
Contributor Author

Okay 😄

@bruno- bruno- merged commit 763d0a8 into tmux-plugins:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants