Skip to content

helix: fix command name, hx: add page #8242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2022
Merged

helix: fix command name, hx: add page #8242

merged 3 commits into from
Jul 23, 2022

Conversation

navarroaxel
Copy link
Collaborator

@navarroaxel navarroaxel commented Jul 22, 2022 •
edited
Loading

  • Version of the command being documented (if known):
  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

Close #8241

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jul 22, 2022
@navarroaxel navarroaxel added the minor change Change(s) to an existing page(s) which is minor. label Jul 22, 2022
@bentarve
Copy link

bentarve commented Jul 22, 2022 •
edited
Loading

The package name is helix but the binary name is hx, so consider to change the file name to hx?

@navarroaxel
Copy link
Collaborator Author

In some distros like Arch, the command is helix or hx. we should create an alias page.

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jul 22, 2022
@navarroaxel navarroaxel changed the title helix: fix command name helix: fix command name, hx: add page Jul 22, 2022
mfrw
mfrw approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you @navarroaxel :)

@blueskyson blueskyson merged commit ad38933 into main Jul 23, 2022
@blueskyson blueskyson deleted the pages/helix branch July 23, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfrw mfrw mfrw approved these changes

@blueskyson blueskyson blueskyson approved these changes

@EmilyGraceSeville7cf EmilyGraceSeville7cf Awaiting requested review from EmilyGraceSeville7cf

@marchersimon marchersimon Awaiting requested review from marchersimon

Assignees

No one assigned

Labels

minor change Change(s) to an existing page(s) which is minor. new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

typo in helix page

4 participants

@navarroaxel @bentarve @mfrw @blueskyson