fix: correct race condition from connection params in HCI implementatation #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sago35
reviewed
Jan 4, 2025
Member
sago35
left a comment
sago35
left a comment
There was a problem hiding this comment.
I don't fully understand the details. Adding debug prints and comments seems fine to me. Please let me confirm only the parts where the intention behind the changes is unclear.
deadprogram
force-pushed
the
fixes-hci-connection-race
branch
from
c3abc61 to
5087ac6
Compare
Member
Author
|
@sago35 PR has been commented/updated. |
deadprogram
force-pushed
the
fixes-hci-connection-race
branch
from
5087ac6 to
b6d4b79
Compare
…ion. Basically it was responding by calling a function that retriggered asking to change the parameters yet again. Yet we are not actually doing anything about this request at present. Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
fixes-hci-connection-race
branch
from
b6d4b79 to
5eb15c7
Compare
Member
Author
|
I think I have now addressed all feedback/comments. Thanks for helping out @sago35 now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to correct race condition from connection params in HCI implementatation.
Basically it was responding by calling a function that retriggered asking to change the parameters yet again. Yet we are not actually doing anything about this request at present.
Along the way to debugging this, I added some additional comments. Also added a specific error returned to allow the service discovery to know when there are no more services to be found.