Skip to content

rm caBundle #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

rm caBundle #433

merged 1 commit into from
Jan 9, 2025

Conversation

@KrystianMarek
Copy link

@KrystianMarek KrystianMarek commented Jan 7, 2025 •
edited
Loading

Description

Drop caBundle from CRDs to support Kubernetes 1.31
kubernetes-sigs/cluster-api#10972

Why is this needed

Allow provider to work with k8s 1.31

Fixes: #

message: 'action failed after 10 attempts: failed to patch provider object: CustomResourceDefinition.apiextensions.k8s.io
      "tinkerbellclusters.infrastructure.cluster.x-k8s.io" is invalid: spec.conversion.webhookClientConfig.caBundle:
      Invalid value: []byte{0xa}: unable to load root certificates: unable to parse
      bytes as PEM block'

Tests:

Deployed on local k8s 1.31, with tilt.

rm caBundle
fc12604 
Signed-off-by: Krystian Marek <[email protected]>
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Jan 8, 2025
@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Jan 9, 2025

@KrystianMarek i don't recall the semantics of the API server pre 1.31. How does this impact deployments to Kube <1.31?

1 similar comment
@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Jan 9, 2025

@KrystianMarek i don't recall the semantics of the API server pre 1.31. How does this impact deployments to Kube <1.31?

@mergify mergify bot merged commit 97ed2ed into tinkerbell:main Jan 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobweinstock jacobweinstock jacobweinstock approved these changes

Assignees

No one assigned

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KrystianMarek @chrisdoherty4 @jacobweinstock