Fix tinkerbell machine reconciliation bug #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Ganesh <[email protected]>
jacobweinstock
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is going to make the reconciler return early when we find that the hardware owned by the tinkerbellmachine is already provisioned.
Why is this needed
When the hardware machine is provisioned there's nothing to reconcile, we missed returning early which caused the machine reconciler to recreate the workflows and this lead to machine getting provisioned again whenever the CAPT and TNK objects moved from one cluster to another.
Fixes: #
How Has This Been Tested?
Tested a local build to ensure the machine wasn't reprovisioned after moving from one cluster to another.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: