Skip to content

Conversation

rahulbabu95
Copy link

Description

This change is going to make the reconciler return early when we find that the hardware owned by the tinkerbellmachine is already provisioned.

Why is this needed

When the hardware machine is provisioned there's nothing to reconcile, we missed returning early which caused the machine reconciler to recreate the workflows and this lead to machine getting provisioned again whenever the CAPT and TNK objects moved from one cluster to another.

Fixes: #

How Has This Been Tested?

Tested a local build to ensure the machine wasn't reprovisioned after moving from one cluster to another.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Jan 4, 2025
@mergify mergify bot merged commit 05c0684 into tinkerbell:main Jan 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants