Update how network booting is disabled

[jacobweinstock]

Currently, CAPT tells Smee to not allowing a machine to network boot after it has been provisioned. This happens by CAPT setting 2 values in a Hardware object. Hardware.Spec.Metadata.Instance.State = provisioned and Hardware.Spec.Metadata.State = in_use.

cluster-api-provider-tinkerbell/controllers/machine_reconcile_scope.go

Line 52 in d828a9e

inUse = "in_use"

cluster-api-provider-tinkerbell/controllers/machine_reconcile_scope.go

Line 53 in d828a9e

provisioned = "provisioned"

cluster-api-provider-tinkerbell/controllers/machine_reconcile_scope.go

Line 110 in d828a9e

return hw.Spec.Metadata.State == inUse && hw.Spec.Metadata.Instance.State == provisioned

cluster-api-provider-tinkerbell/controllers/machine_reconcile_scope.go

Line 187 in d828a9e

if err := scope.patchHardwareStates(hw, inUse, provisioned); err != nil {

cluster-api-provider-tinkerbell/controllers/machine_reconcile_scope.go

Line 723 in d828a9e

hardware.Spec.Metadata.State = ""

cluster-api-provider-tinkerbell/controllers/machine_reconcile_scope.go

Line 724 in d828a9e

hardware.Spec.Metadata.Instance.State = ""

This was the case because Smee was using these fields to gate network booting. This is no longer the case in Smee (since v0.10.0). Gating of network booting in Smee now occurs via Hardware.Spec.Interfaces[].Netboot.AllowPXE.

The affect of this is that when a machine reboots, if the firmware is setup to network boot first, then the machine will be served network boot packets from Smee and the machine will boot into HookOS and sit there indefinitely.

Expected Behaviour

A machine provisioned by CAPT should not network boot after a reboot (hardware configured to tell Smee not to netboot a machine).

Current Behaviour

Possible Solution

Update CAPT to set Hardware.Spec.Interfaces[].Netboot.AllowPXE = false after a machine is provisioned.

Steps to Reproduce (for bugs)

1. Provision a cluster with CAPT
2. Set a machine's firmware to network boot
3. Reboot the machine
4. See that HookOS is loaded and sits indefinitely

Context

Your Environment

• Operating System and version (e.g. Linux, Windows, MacOS):

• How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

• Link to your project or a code example to reproduce issue: