-
Notifications
You must be signed in to change notification settings - Fork 739
*: update sys in go.mod to fix panic when using golang1.17 #4058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4058 +/- ##
==========================================
- Coverage 74.62% 74.59% -0.03%
==========================================
Files 257 257
Lines 25972 25972
==========================================
- Hits 19381 19375 -6
Misses 4867 4867
- Partials 1724 1730 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 57f5bd9
|
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang [email protected]
What problem does this PR solve?
Without this fix running a binary can cause a panic, see upstream go issue: golang/go#45702
What is changed and how it works?
Bump x/sys so that this project supports go 1.17.
Check List
Tests
Release note