Skip to content

Conversation

@thomasp85
Copy link
Member

No description provided.

@thomasp85 thomasp85 requested a review from teunbrand October 28, 2025 17:07
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some recurring issues. I expect that if we fix these, a bunch of the 'can't build vignette' errors (which I haven't investigated deeply) will also dissolve.

Comment on lines +78 to +79
Error in FUN(X[[i]], ...) : object of type 'symbol' is not subsettable
Calls: <Anonymous> ... <Anonymous> -> get_labels -> normalise_label -> lapply
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a recurring issue, should investigate a bit but I expect this is a simple bug.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, typo.

23. └─vctrs:::stop_scalar_type(`<fn>`(`<expression>`), "x$label", `<env>`)
24. └─vctrs:::stop_vctrs(...)
25. └─rlang::abort(message, class = c(class, "vctrs_error"), ..., call = call)
! When `palette = NULL`, the `fallback.palette` must be defined.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a recurring issue that may require some thoughts

Comment on lines +1215 to +1216
14. └─ggplot2 (local) compute_geom_1(..., self = self)
15. └─ggplot2:::check_required_aesthetics(...)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a recurring pattern. Should investigate a bit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error caused by partial matching.

Comment on lines +878 to +879
Codoc mismatches from Rd file 'gf_lines.Rd':
gf_abline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes, we just can't win.

@teunbrand teunbrand mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants