-
Notifications
You must be signed in to change notification settings - Fork 2.1k
coord_munch can convert closed shapes to closed form #5081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
The snapshots of maps have revert to their old state after removing the closing point. |
Yes - rectangles always had one too many so this change is considered a fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if you could provide a test that shows how this fixes rendering of closed paths it would be great
This PR aims to fix #3271.
In brief:
rect_to_poly()
function ingeom_rect()
made a redundant edge. While amending this, I found a more efficient way to polygonise rectangles, which is 2x faster for n = 2 rectangles, but 200x faster for n = 1000 rectangles.A visual comparison:
Before:
After:
Created on 2022-12-03 by the reprex package (v2.0.1)