Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Feb 6, 2021

Just a 15 minute experiment. I have no recollection of how the facet data structure works, so this is just banging rocks together.

Fixes #4175

@hadley
Copy link
Member Author

hadley commented Feb 7, 2021

  • When implementing this for real, may want to do it in such away that the non-vctrs code lives on so we can give the users the ability to switch back to the old version if desired
  • Need to fundamentally rethink how facet data matching works using vctrs primiitves

@thomasp85 thomasp85 mentioned this pull request May 20, 2022
@thomasp85 thomasp85 added this to the ggplot2 3.4.0 milestone May 20, 2022
@thomasp85 thomasp85 mentioned this pull request Jun 10, 2022
@thomasp85
Copy link
Member

Closing in favour of #4868

@thomasp85 thomasp85 closed this Jun 24, 2022
@thomasp85 thomasp85 deleted the vctrs branch October 6, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ggplot breaks when facet variable is POSIXct with tz attribute specified

3 participants