feat(all): update packages, tests, links #515
Conversation
cb1kenobi
left a comment
cb1kenobi
left a comment
There was a problem hiding this comment.
This PR is a great first step! Thanks for working on this.
| "sprintf": "^0.1.5", | ||
| "temp": "~0.9.4", | ||
| "uuid": "~8.3.2", | ||
| "uuid": "~9.0.0", |
There was a problem hiding this comment.
I'd have to test this, but I'm hesitant to blind merge a major bump.
There was a problem hiding this comment.
only tested it on Linux. btw: I don't see where it is used
| } | ||
|
|
||
| return cachedStatus = result; | ||
| exports.login = function login(_args) {}; |
There was a problem hiding this comment.
Elsewhere you had to put a comment in the body of a scope to I believe make lint happy. I'm curious why linting complained elsewhere, but not here? FWIW, I do prefer the empty body as you have it.
There was a problem hiding this comment.
I prefer this too, even for the code blocks in an if or catch. We could add allowEmptyCatch to ignore this warning
There was a problem hiding this comment.
Yeah, I say we add allowEmptyCatch (which I didn't know existed!)
allowEmptyCatchrule to ignore empty blocks