Skip to content

Mock managers #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 78 commits into from
Mar 15, 2019
Merged

Mock managers #5

merged 78 commits into from
Mar 15, 2019

Conversation

mpangburn
Copy link

Features:

  • Pump simulator with controllable reservoir and battery, ability to force errors on bolus/temp/suspend/resume.
  • CGM simulator with controllable glucose production model (constant or sine curve) and composable effects (glucose noise, random outliers, random errors).
  • Simulator configuration via settings; ability to clear out simulator data from HealthKit.

Notes:

  • Strings are deliberately not localized; this is a development tool and not for production.
  • Bolus and suspend states don't make use of transitional "bolusing" or "suspending" states.

ps2 and others added 30 commits November 19, 2018 17:50
@ps2
Allow setting of PumpManagerSetupViewController pump settings
e02991b
@ps2
Add suspend/resume
a2bb268
@ps2
Add pump manager delegate callback for suspend/resume updates
f2c0646
@ps2
Bundle battery, suspend, and bolusing status into PumpManagerStatus o…
a56b274 
…bject, and cleanup NS upload
@ps2
Custom HUD views from PumpManager
d362c1e
@ps2
Naming updates
58ac68f
@ps2
Allow LevelHUDView to be subclassed
b0da51e
@ps2
Move state colors to BaseHUDView
247d7e5
@ps2
LoadingTableViewCell
ae2ddd8
@ps2
HUDProvider protocol
ea6b354
@ps2
Merge in swift 4.2 updates from dev
0d0d1e1
@ps2
Return DoseEntry for requested bolus, including duration
8fe99cc
@ps2
Add method to round delivery units to nearest supported volume
ba503b1
@ps2
Multiple observers of status, and suspend-resume cell
200b1d8
@ps2
Fix inadvertent edit
baa1cd6
@ps2
Extend UIAlertController instead of defining new class for error alerts
7d77370
@ps2
Expose LoopKit error UI for reuse
5a02a7e
@ps2
Method for removing hud views, and fix return type of suspend/resume
9b94e15
@ps2
Fix fast transitions leaving checkbox visible when it shouldn't be
1908cdc
@ps2
Decrease section header size when setup screens don't fit vertically
3fe4366
@ps2
Remove debug print
b478ff4
@ps2
Expose setupNavigationController
0eb9a89
@ps2
Pairing progress updates
0f96af0
@mpangburn
WIP mock managers
46976f2 
(pushing early to simplify workspace setup, still much to do here)
@mpangburn
Mock manager cleanup
c5da300
@mpangburn
Mock managers
65654f4
@mpangburn
Merge branch 'mock-managers' of https://github.com/tidepool-org/LoopKit…
1f3e754 
… into mock-managers

# Conflicts:
#	LoopKit/Extensions/Collection.swift
#	LoopKitUI/MockPumpManager+UI.swift
#	LoopKitUI/View Controllers/MockCGMManagerSettingsViewController.swift
@mpangburn
Refactor mock managers into separate frameworks
a9afa27
@mpangburn
Mark MockKit and MockKitUI as shared
e79f081
@mpangburn
Dynamic plugin support
9d243e9
ps2 and others added 19 commits February 14, 2019 15:22
@ps2
WeakObserverSet -> WeakSet
8a729ae
@ps2
Add hudWillDisappear method to HUDProvider
d1ceb09
@ps2
Use active flag instead of appear/disapper methods
4136d52
@ps2
Merge in pumpmanager-changes
4126ab9
@ps2
Merge in pumpmanager-updates
69b9b61
@ps2
Allow out of bounds values for level, but bound internally
f0c7f78
@ps2
HUDProvider active -> visible
572269a
@ps2
Merge branch 'pumpmanager-updates' of github.com:LoopKit/LoopKit into…
989795c 
… pumpmanager-updates
@ps2
Merge remote-tracking branch 'origin/pumpmanager-updates' into mock-m…
ccba623 
…anagers-pm-merge
@ps2
HUDProvider active -> visible
c73cd5a
@mpangburn
Merge pull request #2 from tidepool-org/mock-managers-pm-merge
67bd1d7 
Mock managers update
@ps2
Merge in dev
2d9de36
@mpangburn
Mock managers
65bc26a
@mpangburn
Merge branch 'mock-managers' of https://github.com/tidepool-org/LoopKit…
11f7f1b 
… into mock-managers
@mpangburn
Move MockHUDProvider to separate file
5563a56
@mpangburn
Unique data identifiers for mock pump events
bc4873f
@mpangburn
Remove MockKitUITests target
20e37a4
@mpangburn
Introduce LoopTestingKit
85e6e80
@mpangburn
Enforce data point frequency
7d4cfc3
@mpangburn mpangburn mentioned this pull request Mar 5, 2019
Merged
mpangburn added 2 commits March 5, 2019 18:43
@mpangburn
Merge branch 'tidepool-dev' into mock-managers
0eef72a 
# Conflicts:
#	LoopKit.xcodeproj/project.pbxproj
@mpangburn
Basal picker support
98b7ca5
@mpangburn mpangburn requested review from darinkrauss and ps2 March 6, 2019 02:48
ps2
ps2 approved these changes Mar 11, 2019
View reviewed changes
Copy link

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits. Looks great!

@ps2 ps2 merged commit ff6041d into dev Mar 15, 2019
@ps2 ps2 deleted the mock-managers branch April 3, 2019 14:41
@ps2 ps2 mentioned this pull request Dec 31, 2019
Merged
ps2 pushed a commit that referenced this pull request Apr 21, 2023
@novalegra
Add missed meal notifications to Loop (#428)
65bf31d 
* Add unannounced meal func to CarbStoreProtocol

* V1 of UAM algo

* Fix issues with time intervals not lining up

* Fix issue with ICE not being cumulative

* Make carb threshold a static const

* Handle errors in fetching glucose effects

* Add date range unit test

* Style improvement

* Update build settings so watch can access LoopNotificationUserInfoKey

* Add debug info for feature to carbstore

* Remove unneeded variable set

* Save last UAM notification time in UserDefaults

* Add debug info

* Update naming to make constant transition easier

* Use constants instead of variables

* Only restrict notification delivery so we don't detect the same meal twice

* Retract UAM notifications after the carbs have expired

* Simplify change & meal checks into a single threshold

* Fix effects from outside of the search window being included & triggering false-positive UAM detections

* Improve function naming

* Add enhanced debug info

* Move notification logic from LoopKit to Loop

* Improve debug logs

* Make current date configurable

* Add preliminary tests

* Add test

* Fix carb entries being purged bc of current date not being set during unit testing

* Update UAM tests

* Update status enum naming for point-of-use clarity

* Fix observation start for unit testing

* Pull UAM constants into separate struct

* Fix unexpected effect not including all needed effects

* Fix carb effects not being carb _counteraction_ effects

* Update tests for algo changes

* Add noisy cgm testcase

* Add test for non-unannounced meal with COB

* Add realistic unannounced meal test

* Improve algo commenting

* Update UAM algo to detect more-aggressively

* Remove TODO

* Update debug information

* Schedule missed meal notifications to avoid notification during an microbolus (#2)

* Add ability to estimate delivery duration of bolus

* Add tests for UAM notification delay

* Update `estimatedDuration` function headers in response to PR feedback

* Add UAM banner to carb entry screen (#4)

* UAM algo updates: only use directly observed carb absorption (#5)

* Add ability to calculate the number of carbs in a missed meal (#3)

* Plumb a customizable carb amount through UAM notification architecture

* Refactor carb effect threshold computation into helper function

* Add first draft of dynamic carb selection for meal

* Bump max carb autofill limit from 100 -> 150

* Add tests for carb autofill

* Bump max carb threshold limit because of dynamic autofill clamping

* Lower the UAM max autofill

* Require that unannounced meals have ICE onboard that is >= the meal threshold, and only autofill observed ICE

* Lower ICE threshold for a UAM notification

* Update tests

* Improve debug info

* Update commenting

* Remove unused test

* Update test

* `dateRange` -> `simulationDateRange`

* Create `MealDetectionManager` from old UAM functions in `CarbStore`

* Add fixme

* Updates based on feedback for UAM PR (#6)

* `dateRange` -> `simulationDateRange`

* Create `MealDetectionManager` from old UAM functions in `CarbStore`

* Add fixme

* Move UAM test fixtures from LoopKit to Loop

* Unannounced meal / UAM -> missed meal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps2 ps2 ps2 approved these changes

@darinkrauss darinkrauss Awaiting requested review from darinkrauss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpangburn @ps2