Add a utility function for checking io_uring permissions #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
nomt/src/io/mod.rs
Outdated
|
|
||
| /// Check whether the current device has permission to use io_uring. | ||
| /// | ||
| /// On non-Linux platforms, this will always return `NotSupported`.` |
There was a problem hiding this comment.
There's an extra backtick character at the end of this line. It should be:
/// On non-Linux platforms, this will always return `NotSupported`.
Suggested change
| /// On non-Linux platforms, this will always return `NotSupported`.` | |
| /// On non-Linux platforms, this will always return `NotSupported`. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
rphmeier
force-pushed
the
rh-check-iou-perm
branch
from
5608641 to
eddeda3
Compare
nomt/src/lib.rs
Outdated
|
|
||
| /// Check whether the current device has permission to use io_uring. | ||
| /// | ||
| /// On non-Linux platforms, this will always return `NotSupported`.` |
There was a problem hiding this comment.
There's an extra backtick character at the end of this documentation line. The line should be:
/// On non-Linux platforms, this will always return `NotSupported`.
without the trailing backtick.
Suggested change
| /// On non-Linux platforms, this will always return `NotSupported`.` | |
| /// On non-Linux platforms, this will always return `NotSupported`. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
rphmeier
force-pushed
the
rh-check-iou-perm
branch
from
eddeda3 to
c9a226f
Compare
Contributor
Author
Comment on lines
+214
to
+215
| /// It is recommended to check io_uring permissions before calling this function by calling | ||
| /// [`check_iou_permissions`] |
There was a problem hiding this comment.
The documentation link to check_iou_permissions needs a full path to work correctly. Please update it to [crate::check_iou_permissions] to ensure proper linking in the generated documentation.
Suggested change
| /// It is recommended to check io_uring permissions before calling this function by calling | |
| /// [`check_iou_permissions`] | |
| /// It is recommended to check io_uring permissions before calling this function by calling | |
| /// [`crate::check_iou_permissions`] |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
rphmeier
changed the base branch from
rh-path-proof-must-use
to
graphite-base/916
rphmeier
force-pushed
the
rh-check-iou-perm
branch
from
c9a226f to
b9cf8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #878