Skip to content

Conversation

AlaaElattar
Copy link
Contributor

Description

  • In case the signatures are gone from the transaction while handling the ready events, we should just ignore the transactions.

Related Issues:

Checklist:

Please delete options that are not relevant.

  • My change requires a change to the documentation and I have updated it accordingly
  • My change requires storage migration and I have included and tested it following fork off and try_runtime instructions.
  • I have added tests to cover my changes.
  • I followed the Release document.
  • My commits follow this conventional commits guide.

Copy link
Member

@sameh-farouk sameh-farouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're relying on TFChain's retry mechanism to re-notify us about the related transaction.
Therefore, I suggest renaming the action to withdraw_postponed and refund_postponed.
The corresponding message should also reflect this for example:
"The withdraw has been postponed due to..."
Also, please include a reason metadata to be consistent with other logs, see withdraw_postponed in handleWithdrawReady().
Maybe add refund_postponed to the bridge/docs/observability.md

@AlaaElattar AlaaElattar requested a review from sameh-farouk June 10, 2025 13:31
@AlaaElattar AlaaElattar requested a review from sameh-farouk June 11, 2025 11:57
@AlaaElattar AlaaElattar merged commit 913f1c8 into development Jun 15, 2025
1 check passed
@AlaaElattar AlaaElattar deleted the development_race_condition branch June 15, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants