Skip to content

chore(pallet-tft-bridge): remove rustc 1.77 warnings #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

chore(pallet-tft-bridge): remove rustc 1.77 warnings #1016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f1d51e
remove rustc 1.77 warnings
renauter Oct 7, 2024
345bd35
skip check-benchmark-weights
renauter Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions substrate-node/pallets/pallet-tft-bridge/src/tft_bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ impl<T: Config> Pallet<T> {

// transfer new amount to target
let amount_as_balance = BalanceOf::<T>::saturated_from(new_amount);
T::Currency::deposit_creating(&tx.target, amount_as_balance);
let _ = T::Currency::deposit_creating(&tx.target, amount_as_balance);
// transfer deposit fee to fee wallet
let deposit_fee_b = BalanceOf::<T>::saturated_from(deposit_fee);

if let Some(fee_account) = FeeAccount::<T>::get() {
T::Currency::deposit_creating(&fee_account, deposit_fee_b);
let _ = T::Currency::deposit_creating(&fee_account, deposit_fee_b);
}

// Remove tx from storage
Expand Down Expand Up @@ -78,7 +78,7 @@ impl<T: Config> Pallet<T> {

// transfer withdraw fee to fee wallet
if let Some(fee_account) = FeeAccount::<T>::get() {
T::Currency::deposit_creating(&fee_account, withdraw_fee_b);
let _ = T::Currency::deposit_creating(&fee_account, withdraw_fee_b);
}

// increment burn transaction id
Expand Down Expand Up @@ -240,9 +240,11 @@ impl<T: Config> Pallet<T> {
Error::<T>::BurnTransactionAlreadyExecuted
);

let Some(mut burn_tx) = BurnTransactions::<T>::get(tx_id) else {return Err(DispatchErrorWithPostInfo::from(
Error::<T>::BurnTransactionNotExists,
));};
let Some(mut burn_tx) = BurnTransactions::<T>::get(tx_id) else {
return Err(DispatchErrorWithPostInfo::from(
Error::<T>::BurnTransactionNotExists,
));
};

ensure!(
BurnTransactions::<T>::contains_key(tx_id),
Expand Down Expand Up @@ -286,9 +288,11 @@ impl<T: Config> Pallet<T> {
stellar_pub_key: Vec<u8>,
sequence_number: u64,
) -> DispatchResultWithPostInfo {
let Some(mut tx) = BurnTransactions::<T>::get(&tx_id) else {return Err(DispatchErrorWithPostInfo::from(
Error::<T>::BurnTransactionNotExists,
));};
let Some(mut tx) = BurnTransactions::<T>::get(&tx_id) else {
return Err(DispatchErrorWithPostInfo::from(
Error::<T>::BurnTransactionNotExists,
));
};

let validators = Validators::<T>::get();
if tx.signatures.len() == (validators.len() / 2) + 1 {
Expand Down Expand Up @@ -346,9 +350,11 @@ impl<T: Config> Pallet<T> {
Error::<T>::BurnTransactionNotExists
);

let Some(tx) = BurnTransactions::<T>::get(tx_id) else {return Err(DispatchErrorWithPostInfo::from(
Error::<T>::BurnTransactionNotExists,
));};
let Some(tx) = BurnTransactions::<T>::get(tx_id) else {
return Err(DispatchErrorWithPostInfo::from(
Error::<T>::BurnTransactionNotExists,
));
};

BurnTransactions::<T>::remove(tx_id);
ExecutedBurnTransactions::<T>::insert(tx_id, &tx);
Expand Down
Loading