Skip to content

Return Message as String View #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
threeal merged 2 commits into from
Dec 25, 2023
Merged

Return Message as String View #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c6011b
feat: modify `Error::message` to return `std::string_view`
threeal Dec 25, 2023
5caa4fb
build: set `CMAKE_CXX_STANDARD` to `17`
threeal Dec 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
set(NOT_SUBPROJECT TRUE)
endif()

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

# Initialize CPM.cmake
include(cmake/CPM.cmake)

Expand Down
3 changes: 2 additions & 1 deletion include/errors/error.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <memory>
#include <ostream>
#include <string>
#include <string_view>
#include <utility>

namespace errors {
Expand All @@ -27,7 +28,7 @@ class Error {
* std::cout << err << std::endl;
* @endcode
*/
std::string message() const;
std::string_view message() const;

friend Error make(const std::string& msg);

Expand Down
2 changes: 1 addition & 1 deletion src/error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ namespace errors {

Error::Error(const std::shared_ptr<const std::string>& message_ptr) : message_ptr(message_ptr) {}

std::string Error::message() const {
std::string_view Error::message() const {
if (!message_ptr) return "no error";
return *message_ptr;
}
Expand Down