Skip to content

Conversation

@threeal
Copy link
Owner

@threeal threeal commented Jun 27, 2023

  • Removed global setting of CMAKE_CXX_STANDARD.
  • Replaced global setting of CMAKE_CXX_FLAGS with target_compile_options to specify warning flags.
  • Set warnings to be treated as errors by default.
  • Modified warning flags to be enabled only if the project is not included as a dependency.
  • Replaced global setting of CMAKE_CXX_FLAGS with target_compile_options and target_link_options to specify coverage flags.
  • Enhanced CMakeLists.txt with descriptive comments.

@threeal threeal added the feat label Jun 27, 2023
@threeal threeal self-assigned this Jun 27, 2023
@threeal threeal force-pushed the cmake-scoped-flags branch from d7fb17b to e2bde1f Compare June 27, 2023 14:44
@threeal threeal marked this pull request as ready for review June 27, 2023 15:28
@threeal threeal merged commit f50eaf3 into main Jun 27, 2023
@threeal threeal deleted the cmake-scoped-flags branch June 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants