Skip to content

Add Support to Create Empty Error #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
threeal merged 2 commits into from
Dec 26, 2023
Merged

Add Support to Create Empty Error #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b06e8c5
test: merge error checking test to error construction test
threeal Dec 26, 2023
2d797b7
feat: add `Error::Error()` constructor
threeal Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/errors/error.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ class Error {
Error(const std::shared_ptr<const std::string>& message_ptr);

public:

/**
* @brief Constructs an empty error object.
*/
Error();

/**
* @brief Returns the error message.
*
Expand Down
2 changes: 2 additions & 0 deletions src/error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ namespace errors {

Error::Error(const std::shared_ptr<const std::string>& message_ptr) : message_ptr(message_ptr) {}

Error::Error() {}

std::string_view Error::message() const {
if (!message_ptr) return "no error";
return *message_ptr;
Expand Down
10 changes: 6 additions & 4 deletions test/error_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
#include <sstream>

TEST_CASE("Error Construction") {
const errors::Error err = errors::make("unknown error");
const auto err = errors::make("unknown error");
REQUIRE(err);
REQUIRE(err.message() == "unknown error");
}

TEST_CASE("Error Checking") {
const auto err = errors::make("unknown error");
REQUIRE(err);
TEST_CASE("Empty Error Construction") {
const errors::Error err;
REQUIRE_FALSE(err);
REQUIRE(err.message() == "no error");
}

TEST_CASE("Error Printing Using OStream") {
Expand Down