Skip to content

Check Warnings Globally #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
threeal merged 2 commits into from
Dec 22, 2023
Merged

Check Warnings Globally #89

threeal merged 2 commits into from
Dec 22, 2023

Conversation

@threeal
Copy link
Owner

@threeal threeal commented Dec 21, 2023

This pull request resolves #87 by substituting the target_check_warning function with the add_check_warning function This change ensures that all targets in the directory are checked for warnings.

Additionally, this pull request also move the if declaration for CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR back onto the same line as the if declaration for BUILD_TESTING, thereby shortening the content of CMakeLists.txt.

@threeal threeal added the build label Dec 21, 2023
@threeal threeal added this to the Version 1.1.0 milestone Dec 21, 2023
@threeal threeal self-assigned this Dec 21, 2023
@threeal threeal marked this pull request as ready for review December 21, 2023 12:44
@threeal threeal merged commit aeaecf5 into main Dec 22, 2023
@threeal threeal deleted the check-warnings-globally branch December 22, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@threeal threeal

Labels

build

Projects

None yet

Milestone

Version 1.1.0

Development

Successfully merging this pull request may close these issues.

Check Warnings Globally

2 participants

@threeal