Skip to content

Conversation

@threeal
Copy link
Owner

@threeal threeal commented Dec 15, 2023

This pull request introduces the following changes:

  • Set coverage flags only to the my_fibonacci_test target.
  • Rebuild source files of the my_fibonacci target instead of linking it to the my_fibonacci_test target. This changes prevent the my_fibonacci target from having coverage flags enabled.
  • Modifies check coverage steps as follows:
    • Removes src/main.cpp file from exclude input, basically include all files but it's safe now because the coverage will only enabled to source files related in testing.
    • Set fail-under-line to be 100, make sure test always covers everything.

It closes #64.

@threeal threeal self-assigned this Dec 15, 2023
@threeal threeal added the build label Dec 15, 2023
@threeal threeal added this to the Version 1.0.0 milestone Dec 15, 2023
@threeal threeal force-pushed the limit-coverage-flags branch from 2159634 to 6e6ce8f Compare December 15, 2023 11:39
@threeal threeal marked this pull request as ready for review December 15, 2023 11:42
@threeal threeal merged commit f3c21d1 into main Dec 15, 2023
@threeal threeal deleted the limit-coverage-flags branch December 15, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit Coverage Flags to Specific Target

2 participants