Custom colors are not honoured

[eltos]

In preferences, the user has the option to assign custom colors.
However, these RGB values are not used as-is, but converted to HSV, then the saturation is set to 100%, and then converted back to RGB:
For example here:

hsv = this.#getNewColour(container.isSent); // returns convertRGBtoHSV(...)
colour = this.#getColour(hsv.hue, 100, hsv.value);

This is not only counter-intuitive and confusing, but also limits the color space one can use.
From a user perspective, the color set in preferences should be used as-is.

Related: #22

[ahubmann]

Uh, many thanks for diving this deep into the code. I did a quick check and it seems the HSV color space is (in the meantime) completely useless, this is a left-over of code before 8bd9e6b where I added the custom colors (15 years ago, yay!).

Before that, I used angle-offset hues to get distinguishable new colors:

Visualisation.prototype.getNewColour = function() {
    var hues = new Array(0,90,180,270,45,135,225,315,0,90,180,270,45,135,225,
        315,0,90,180,270,45,135,225,315,0,90,180,270,45,135,225,315);
    var values = new Array(100,100,100,100,60,60,60,60,60,60,60,60,100,
        100,100,100,80,80,80,80,40,40,40,40,40,40,40,40,80,80,80,80);

    this.lastColour = (this.lastColour + 1) % hues.length;

    return {"hue" : hues[this.lastColour], "value" : values[this.lastColour]};
}

I'll verify this and then get rid of the rgb to hsv to rgb conversion, on first glance I'm always setting saturation to 100 in all conversions, so staying within the RGB color space should simplify this quite a bit.

[eltos]

Makes sense.
BTW many thanks for this great Add-On, I wish I had discovered it earlier ;)

[ahubmann]

Just realised I never released 3.5.2, which includes the above mentioned changes. Working on 3.6.0 meanwhile for Thunderbird 128, so the rgb->hsv->rgb conversion will be a thing of the past soon.

[ahubmann]

Fixed in 3.6.0. Closing.