Skip to content

Conversation

@PerryRose
Copy link

@PerryRose PerryRose commented Apr 5, 2022

Description

This pull request migrates the grade-task-modal component from AngularJS to Angular.
The grade task modal component is opened from task-service.coffee using the grade task modal service, which receives a task object and passes it onto the component via a MatDialogRef. Depending on the task object, a student's submission can either be rated using a Mat Slider, or graded with a Mat Button Toggle Group, which uses the grade-icon component which I have migrated. Clicking the submit button calls the component's close function, which passes a rating and a grade value back to the service before then being passed back to task-service.coffee, which updates the task object on the backend.

Quality Points Task

Before:

image

After:

image

Graded Task

Before:

image

After:

image

Fixes # (updates the old grade-task-modal component specified outlined in the migration task list)

Type of change

Please delete options that are not relevant.

  • Component migration

How Has This Been Tested?

  1. Log in as an admin
  2. Go to Manage Units and choose a unit
  3. Go to Tasks and choose a task
  4. Go to Other Settings
  5. To grade a task, tick the Graded option.
  6. To rate a task, select a number for the Quality Points option
  7. Save
  8. Log in as a tutor
  9. Go to Mark by Task Definition
  10. Select a task
  11. Select a submission and provide a rating

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from _ and _ on the Pull Request

weijieni added a commit to weijieni/doubtfire-web that referenced this pull request Apr 20, 2022
refactor(component): admin header notification tab (still in progress)
@PerryRose
Copy link
Author

@PerryRose PerryRose force-pushed the migrate/grade-task-modal branch from b02b377 to bdec140 Compare May 14, 2022 01:09
@PerryRose PerryRose marked this pull request as ready for review May 14, 2022 01:10
@PerryRose PerryRose requested a review from RayGuo-ergou May 14, 2022 01:51
Copy link

@RayGuo-ergou RayGuo-ergou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PerryRose for you work, it looks pretty good to me. Just leave few suggestions and tell me what you think.

@RayGuo-ergou
Copy link

One more thing, I think you fotget to run prettier on html file.

@PerryRose
Copy link
Author

Thanks for the feedback @RayGuo-ergou, I have addressed these changes.

@PerryRose PerryRose force-pushed the migrate/grade-task-modal branch from faeaf4b to f813a56 Compare May 17, 2022 09:53
Copy link

@RayGuo-ergou RayGuo-ergou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work

@PerryRose PerryRose requested a review from Ishrat420 May 18, 2022 22:11
Copy link

@Ishrat420 Ishrat420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Perry.

@PerryRose PerryRose requested a review from tancnle May 19, 2022 22:06
@tancnle
Copy link

tancnle commented May 20, 2022

@PerryRose Sorry for the delay. I am reviewing it today.

Copy link

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PerryRose. I have left some suggestions for your consideration. Please let me know what you think 🙏🏼

@PerryRose PerryRose force-pushed the migrate/grade-task-modal branch 2 times, most recently from 4658115 to 2e4dde8 Compare May 22, 2022 01:58
Copy link

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for considering the feedback @PerryRose 🙇🏼 I have a tiny suggestion. We are really close.

@tancnle
Copy link

tancnle commented May 28, 2022

Look really good to me @PerryRose. Thank you for your consideration of my feedback ❤️. I've left one minor comment. It is good to merge otherwise.

Copy link

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @PerryRose ❤️ Let's launch this into orbit 🚀

@PerryRose PerryRose merged commit c43bdd9 into development May 28, 2022
satikaj added a commit to coskun-kilinc/doubtfire-web that referenced this pull request Feb 3, 2025
Add hierarchical sorting for feedback templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants