-
Notifications
You must be signed in to change notification settings - Fork 137
migrate: grade-task-modal #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
refactor(component): admin header notification tab (still in progress)
b02b377 to
bdec140
Compare
RayGuo-ergou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PerryRose for you work, it looks pretty good to me. Just leave few suggestions and tell me what you think.
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.ts
Outdated
Show resolved
Hide resolved
|
One more thing, I think you fotget to run prettier on html file. |
|
Thanks for the feedback @RayGuo-ergou, I have addressed these changes. |
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.html
Outdated
Show resolved
Hide resolved
faeaf4b to
f813a56
Compare
RayGuo-ergou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work
Ishrat420
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job Perry.
|
@PerryRose Sorry for the delay. I am reviewing it today. |
tancnle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @PerryRose. I have left some suggestions for your consideration. Please let me know what you think 🙏🏼
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.html
Outdated
Show resolved
Hide resolved
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.html
Outdated
Show resolved
Hide resolved
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.html
Outdated
Show resolved
Hide resolved
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.html
Outdated
Show resolved
Hide resolved
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.html
Outdated
Show resolved
Hide resolved
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.scss
Outdated
Show resolved
Hide resolved
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.html
Outdated
Show resolved
Hide resolved
4658115 to
2e4dde8
Compare
tancnle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for considering the feedback @PerryRose 🙇🏼 I have a tiny suggestion. We are really close.
src/app/tasks/modals/grade-task-modal/grade-task-modal.component.ts
Outdated
Show resolved
Hide resolved
|
Look really good to me @PerryRose. Thank you for your consideration of my feedback ❤️. I've left one minor comment. It is good to merge otherwise. |
tancnle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @PerryRose ❤️ Let's launch this into orbit 🚀
Add hierarchical sorting for feedback templates
Description
This pull request migrates the grade-task-modal component from AngularJS to Angular.
The grade task modal component is opened from task-service.coffee using the grade task modal service, which receives a task object and passes it onto the component via a MatDialogRef. Depending on the task object, a student's submission can either be rated using a Mat Slider, or graded with a Mat Button Toggle Group, which uses the grade-icon component which I have migrated. Clicking the submit button calls the component's close function, which passes a rating and a grade value back to the service before then being passed back to task-service.coffee, which updates the task object on the backend.
Quality Points Task
Before:
After:
Graded Task
Before:
After:
Fixes # (updates the old grade-task-modal component specified outlined in the migration task list)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Testing Checklist:
Checklist: