-
Notifications
You must be signed in to change notification settings - Fork 28
Refactor https #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor https #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into refactor_https
This was
linked to
issues
Jan 19, 2021
The crash I am getting seems to be upstream in
Someone posted what they think fixes it here but I'm not sure if it happens enough to hack the arduino-esp32 code. |
This was referenced Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probable help for #128 and #129. Still occasionally panics within
HTTPClient::sendRequest()
but I'm beating on it pretty hard (four sheets every 10 seconds.)Removes SecureWithRedirects completely since
HTTPClient::setFollowRedirects()
is now a thing.Have also moved back to the regular WiFiManager and AsyncWebServer since they seem to now work well together.
Additionally, I have removed the DHCP hack since that kills the stack with the current arduino-esp32 packages.