Skip to content

Conversation

@thomhurst
Copy link
Owner

@thomhurst thomhurst commented Dec 10, 2025

This PR contains the following updates:

Package Type Update Change
TUnit nuget patch 1.5.35 -> 1.5.42
TUnit.Assertions nuget patch 1.5.35 -> 1.5.42
TUnit.Assertions.FSharp nuget patch 1.5.35 -> 1.5.42
TUnit.Core nuget patch 1.5.35 -> 1.5.42
TUnit.Playwright nuget patch 1.5.35 -> 1.5.42

Release Notes

thomhurst/TUnit (TUnit)

v1.5.42: 1.5.42

What's Changed
🏕 Changes
  • feat: add DynamicTestIndex property for unique test ID generation in dynamic tests by @​thomhurst in #​4056

Full Changelog: v1.5.41...v1.5.42

v1.5.41: 1.5.41

What's Changed
🏕 Changes
  • Fix documentation: TestContext.Dependencies.GetTests() is the correct public API by @​Copilot in #​4050
  • feat: prevent side effects from non-IAsyncInitializer property getters during discovery by @​thomhurst in #​4054

Full Changelog: v1.5.37...v1.5.41

v1.5.37: 1.5.37

What's Changed
🏕 Changes
  • fix: Collection.Count(lambda) returns a collection-type assertion builder for further collection assertion chaining by @​thomhurst in #​4043
👒 Dependencies

Full Changelog: v1.5.35...v1.5.37


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copilot AI review requested due to automatic review settings December 10, 2025 20:09
@thomhurst thomhurst added dependencies Pull requests that update a dependency file PATCH renovate-bot labels Dec 10, 2025
@thomhurst thomhurst enabled auto-merge (squash) December 10, 2025 20:09
@claude
Copy link
Contributor

claude bot commented Dec 10, 2025

PR Review: Dependency Update to TUnit 1.5.37

✅ Overall Assessment: APPROVED

This is a clean, automated dependency update from Renovate Bot that updates TUnit packages from version 1.5.35 to 1.5.37.


Code Quality & Best Practices ✓

Strengths:

  • Consistent versioning: All TUnit package references updated uniformly across all templates
  • Central package management: Changes correctly made to Directory.Packages.props for centralized version control
  • Template consistency: All template project files (C#, F#, VB) updated consistently
  • Version alignment: All packages (TUnit, TUnit.Core, TUnit.Assertions, TUnit.Assertions.FSharp, TUnit.Playwright) updated to the same version

Modified Files:

  • Directory.Packages.props (central version control)
  • 9 template project files across different languages and scenarios

What's in v1.5.37?

According to the release notes, this patch version includes:

  • Fix: Collection.Count(lambda) now returns a collection-type assertion builder for further collection assertion chaining (#4043)

This is a bug fix that improves the fluent assertion API for collections.


Potential Issues: None Found ✓

  • ✅ No security concerns
  • ✅ No breaking changes (patch version bump)
  • ✅ No performance regressions expected
  • ✅ All template formats updated (C#, F#, VB)
  • ✅ All template scenarios covered (AspNet, Aspire, Playwright, standard)

Test Coverage: N/A (Template Update)

Since this PR only updates version numbers in template files and the central package manifest, no code changes require testing. The actual TUnit 1.5.37 release has already been tested and validated.


Security Considerations ✓

  • ✅ Updating to the latest patch version includes any security fixes
  • ✅ No new dependencies introduced
  • ✅ Renovate Bot automated update with transparent changelog

Recommendations

Safe to merge

This is a straightforward patch version update that:

  1. Fixes a known issue with collection assertions
  2. Keeps templates in sync with the latest stable TUnit release
  3. Follows semantic versioning (patch bump only)

The PR has automerge enabled, which is appropriate for this type of dependency update.


Reviewed against CLAUDE.md guidelines: This change doesn't touch any core TUnit code, so dual-mode implementation, snapshot testing, and other development rules don't apply. This is purely a version bump in template files.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates TUnit package dependencies from version 1.5.35 to 1.5.37 across template projects and central package management. The update includes a bug fix for Collection.Count(lambda) assertion chaining functionality.

Key changes:

  • Updated TUnit core packages (TUnit, TUnit.Core, TUnit.Assertions) to version 1.5.37
  • Updated template project references across C#, VB.NET, F#, Playwright, and Aspire templates

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Directory.Packages.props Updates centralized package versions for TUnit, TUnit.Core, and TUnit.Assertions to 1.5.37
TUnit.Templates/content/TUnit/TestProject.csproj Updates TUnit package reference in C# template to 1.5.37
TUnit.Templates/content/TUnit.VB/TestProject.vbproj Updates TUnit package reference in VB.NET template to 1.5.37
TUnit.Templates/content/TUnit.Playwright/TestProject.csproj Updates TUnit.Playwright package reference in Playwright template to 1.5.37
TUnit.Templates/content/TUnit.FSharp/TestProject.fsproj Updates TUnit and TUnit.Assertions.FSharp package references in F# template to 1.5.37
TUnit.Templates/content/TUnit.Aspire.Test/ExampleNamespace.csproj Updates TUnit package reference in Aspire test template to 1.5.37
TUnit.Templates/content/TUnit.Aspire.Starter/ExampleNamespace.TestProject/ExampleNamespace.TestProject.csproj Updates TUnit package reference in Aspire starter template to 1.5.37
TUnit.Templates/content/TUnit.AspNet/TestProject/TestProject.csproj Updates TUnit package reference in ASP.NET template to 1.5.37
TUnit.Templates/content/TUnit.AspNet.FSharp/TestProject/TestProject.fsproj Updates TUnit and TUnit.Assertions.FSharp package references in ASP.NET F# template to 1.5.37

<PackageVersion Include="Testcontainers.PostgreSql" Version="4.9.0" />
<PackageVersion Include="Testcontainers.Redis" Version="4.9.0" />
<PackageVersion Include="trxparser" Version="0.5.0" />
<PackageVersion Include="TUnit.Assertions.FSharp" Version="0.75.38-PullRequest3485.0" />
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TUnit.Assertions.FSharp package version is inconsistent with the other TUnit packages being updated in this PR. This package is still at version "0.75.38-PullRequest3485.0" while TUnit, TUnit.Core, and TUnit.Assertions are being updated to 1.5.37. According to the PR metadata, TUnit.Assertions.FSharp should also be updated to 1.5.37 to match the other packages.

Suggested change
<PackageVersion Include="TUnit.Assertions.FSharp" Version="0.75.38-PullRequest3485.0" />
<PackageVersion Include="TUnit.Assertions.FSharp" Version="1.5.37" />

Copilot uses AI. Check for mistakes.
<PackageVersion Include="TUnit.Assertions" Version="1.5.35" />
<PackageVersion Include="TUnit" Version="1.5.37" />
<PackageVersion Include="TUnit.Core" Version="1.5.37" />
<PackageVersion Include="TUnit.Assertions" Version="1.5.37" />
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TUnit.Playwright package is missing from the centralized package version management, but is being updated to version 1.5.37 in the template files (e.g., TUnit.Templates/content/TUnit.Playwright/TestProject.csproj). To maintain consistency with the central package management approach used in this project, TUnit.Playwright should be added here with Version="1.5.37".

Suggested change
<PackageVersion Include="TUnit.Assertions" Version="1.5.37" />
<PackageVersion Include="TUnit.Assertions" Version="1.5.37" />
<PackageVersion Include="TUnit.Playwright" Version="1.5.37" />

Copilot uses AI. Check for mistakes.
@claude
Copy link
Contributor

claude bot commented Dec 11, 2025

PR Review: TUnit 1.5.35 → 1.5.37 Update

Overview

This Renovate Bot PR updates TUnit package references from version 1.5.35 to 1.5.37 across template projects and the central package management file.


✅ Positive Findings

1. Consistency & Correctness

  • All package version updates are consistent across the entire codebase
  • Central package management (Directory.Packages.props) properly updated
  • All template projects (.csproj, .fsproj, .vbproj) updated in sync
  • Version changes align with the changelog (patch updates from v1.5.35 → v1.5.37)

2. Scope Appropriateness

  • Only updates TUnit package references (no unrelated changes)
  • Touches exactly the files that need updating for dependency management
  • No code changes, only version number updates

3. Release Notes Validation
Based on the included release notes, v1.5.37 contains:

This is a legitimate patch release with a bug fix, making the update low-risk.


🔍 Code Quality Assessment

File Changes (9 files total):

  1. Directory.Packages.props - Central package versions ✅
  2. TUnit.Templates/content/TUnit.AspNet.FSharp/TestProject/TestProject.fsproj
  3. TUnit.Templates/content/TUnit.AspNet/TestProject/TestProject.csproj
  4. TUnit.Templates/content/TUnit.Aspire.Starter/ExampleNamespace.TestProject/ExampleNamespace.TestProject.csproj
  5. TUnit.Templates/content/TUnit.Aspire.Test/ExampleNamespace.csproj
  6. TUnit.Templates/content/TUnit.FSharp/TestProject.fsproj
  7. TUnit.Templates/content/TUnit.Playwright/TestProject.csproj
  8. TUnit.Templates/content/TUnit.VB/TestProject.vbproj
  9. TUnit.Templates/content/TUnit/TestProject.csproj

All changes follow the exact same pattern: version string replacement from 1.5.35 to 1.5.37.


🎯 Per CLAUDE.md Guidelines

Rule 1 (Dual-Mode Implementation): ✅ N/A

  • Dependency update only, no implementation changes required

Rule 2 (Snapshot Testing): ✅ N/A

  • No source generator or public API changes in this PR
  • Template files don't generate snapshots

Rule 3 (No VSTest): ✅ PASS

  • No test platform dependencies changed

Rule 4 (Performance First): ✅ N/A

  • Dependency update; actual performance impact from v1.5.37 should be validated via benchmarks if the bug fix affects hot paths

Rule 5 (AOT/Trimming): ✅ N/A

  • No code changes affecting AOT

Code Style: ✅ N/A

  • No code changes

🚨 Considerations & Recommendations

1. Testing Recommendation
Since this updates template projects that end users will scaffold from, consider:

# Verify templates still work after the update
dotnet new install TUnit.Templates
dotnet new tunit -n TestTemplateValidation
cd TestTemplateValidation
dotnet build
dotnet run

2. Changelog Validation
The release notes mention a fix for Collection.Count(lambda) assertion builder chaining. If your templates include example tests using this pattern, verify they benefit from or are compatible with the fix.

3. Automerge Configuration
This PR has automerge enabled. Given:

  • ✅ Patch version (low risk)
  • ✅ Bug fix release (beneficial)
  • ✅ Consistent changes across all files
  • ✅ Automated by Renovate (trusted process)

Automerge is appropriate for this PR, assuming CI passes.


📊 Risk Assessment

Risk Level: 🟢 LOW

Justification:

  • Patch version bump (semantic versioning compliance)
  • Bug fix release (improves reliability)
  • No breaking changes indicated
  • Template-only updates (doesn't affect core TUnit codebase)
  • Renovate Bot automation (consistent, tested process)

✅ Final Verdict

APPROVE

This PR is well-formed, follows TUnit conventions, and safely updates dependencies to incorporate a bug fix. No code quality issues, security concerns, or performance regressions expected.

Recommendation: Merge after CI validation.


📋 Pre-Merge Checklist (Auto-verified)

  • All version updates consistent
  • Central package management updated
  • Template projects updated
  • No unrelated changes
  • Follows semantic versioning
  • Release notes reviewed
  • Low risk assessment

Note: Ensure CI passes before automerge completes.

@claude
Copy link
Contributor

claude bot commented Dec 11, 2025

PR Review: TUnit Dependency Update (1.5.35 → 1.5.37)

✅ Summary

This is a straightforward automated dependency update by Renovate Bot, bumping TUnit packages from version 1.5.35 to 1.5.37 across the codebase.


📋 Review Findings

Code Quality: ✅ EXCELLENT

  • Clean, consistent version bumps across all files
  • No code changes, only version number updates
  • Properly updates both central package management (Directory.Packages.props) and template project files

Files Changed (9 files):

  1. Directory.Packages.props - Central package versions
  2. Template projects (8 files) - Keeps templates in sync with latest versions:
    • TUnit.AspNet.FSharp
    • TUnit.AspNet
    • TUnit.Aspire.Starter
    • TUnit.Aspire.Test
    • TUnit.FSharp
    • TUnit.Playwright
    • TUnit.VB
    • TUnit

Packages Updated:

  • TUnit: 1.5.35 → 1.5.37
  • TUnit.Core: 1.5.35 → 1.5.37
  • TUnit.Assertions: 1.5.35 → 1.5.37
  • TUnit.Assertions.FSharp: 1.5.35 → 1.5.37
  • TUnit.Playwright: 1.5.35 → 1.5.37

🔍 Technical Analysis

What Changed in 1.5.37:

Per the release notes, version 1.5.37 includes:

  • Fix: Collection.Count(lambda) now returns a collection-type assertion builder for further chaining (#4043)

This is a patch release fixing assertion chaining behavior.

Test Coverage: ✅ PASS

  • No functional code changes
  • Templates remain consistent with core package versions
  • Standard dependency update pattern

Performance Considerations: ✅ N/A

  • No performance impact (version numbers only)

Security Concerns: ✅ NONE

  • Internal package update (TUnit dogfooding itself)
  • No external dependencies or security vulnerabilities

Breaking Changes: ✅ NONE

  • Patch version bump (semantic versioning)
  • Backward compatible

✅ Recommendation: APPROVE & MERGE

This PR is safe to merge. It's a standard Renovate Bot dependency update that:

  1. Keeps TUnit templates synchronized with the latest published versions
  2. Includes a bug fix for assertion chaining
  3. Follows proper semantic versioning (patch bump)
  4. Has automerge enabled and should merge automatically once CI passes

No action required - let Renovate complete the automated merge process.

@thomhurst thomhurst changed the title chore(deps): update tunit to 1.5.37 chore(deps): update tunit to 1.5.41 Dec 11, 2025
@claude
Copy link
Contributor

claude bot commented Dec 11, 2025

Pull Request Review

This is an automated dependency update PR from Renovate that bumps TUnit package versions from 1.5.35 to 1.5.41 across the templates and central package management.

✅ Code Quality - APPROVED

Positive Observations:

  • Clean, focused change scope - only version bumps
  • Uses centralized package management (Directory.Packages.props) which is best practice
  • Consistent version alignment across all TUnit packages (Core, Assertions, Assertions.FSharp, Playwright)
  • All template projects updated uniformly

📦 Changes Summary

The PR updates 5 TUnit packages across 9 files:

  • Central Management: Directory.Packages.props (3 packages)
  • Templates: 8 template project files (C#, F#, VB, AspNet, Aspire, Playwright)

🔍 What's in 1.5.35 → 1.5.41

Based on release notes, this includes:

Both are patch releases with bug fixes - safe to merge.

🎯 TUnit Guidelines Compliance

Per CLAUDE.md requirements:

No dual-mode changes - This is a dependency bump, not a feature implementation
No snapshot updates needed - No source generator or public API changes in this PR
No performance impact - Consuming newer versions, not modifying framework
No AOT concerns - Template references only

🧪 Testing Recommendations

Automated Testing:
The PR should pass CI checks which will validate:

  • Template integrity
  • Package resolution
  • Build compatibility

Manual Verification (if desired):

# Test template instantiation and build
dotnet new tunit -o TestTUnit
cd TestTUnit && dotnet test
cd ..

dotnet new tunit-fsharp -o TestTUnitFS  
cd TestTUnitFS && dotnet test

🚀 Recommendation

LGTM - Approve & Merge

This is a routine dependency update with:

  • ✅ Patch-level changes only (bug fixes)
  • ✅ No breaking changes
  • ✅ Automerge is appropriately enabled
  • ✅ Consistent versioning across all packages

The changes in the target versions (prevention of property getter side effects and assertion chaining fixes) are valuable improvements that should be propagated to templates.


Note: Renovate has automerge enabled for this PR, so it should merge automatically once CI passes. No action required unless CI fails.

@thomhurst thomhurst changed the title chore(deps): update tunit to 1.5.41 chore(deps): update tunit to 1.5.42 Dec 11, 2025
This was referenced Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file PATCH renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants