-
-
Notifications
You must be signed in to change notification settings - Fork 109
chore(deps): update tunit to 1.5.42 #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Review: Dependency Update to TUnit 1.5.37✅ Overall Assessment: APPROVEDThis is a clean, automated dependency update from Renovate Bot that updates TUnit packages from version 1.5.35 to 1.5.37. Code Quality & Best Practices ✓Strengths:
Modified Files:
What's in v1.5.37?According to the release notes, this patch version includes:
This is a bug fix that improves the fluent assertion API for collections. Potential Issues: None Found ✓
Test Coverage: N/A (Template Update)Since this PR only updates version numbers in template files and the central package manifest, no code changes require testing. The actual TUnit 1.5.37 release has already been tested and validated. Security Considerations ✓
Recommendations✅ Safe to merge This is a straightforward patch version update that:
The PR has automerge enabled, which is appropriate for this type of dependency update. Reviewed against CLAUDE.md guidelines: This change doesn't touch any core TUnit code, so dual-mode implementation, snapshot testing, and other development rules don't apply. This is purely a version bump in template files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates TUnit package dependencies from version 1.5.35 to 1.5.37 across template projects and central package management. The update includes a bug fix for Collection.Count(lambda) assertion chaining functionality.
Key changes:
- Updated TUnit core packages (TUnit, TUnit.Core, TUnit.Assertions) to version 1.5.37
- Updated template project references across C#, VB.NET, F#, Playwright, and Aspire templates
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updates centralized package versions for TUnit, TUnit.Core, and TUnit.Assertions to 1.5.37 |
| TUnit.Templates/content/TUnit/TestProject.csproj | Updates TUnit package reference in C# template to 1.5.37 |
| TUnit.Templates/content/TUnit.VB/TestProject.vbproj | Updates TUnit package reference in VB.NET template to 1.5.37 |
| TUnit.Templates/content/TUnit.Playwright/TestProject.csproj | Updates TUnit.Playwright package reference in Playwright template to 1.5.37 |
| TUnit.Templates/content/TUnit.FSharp/TestProject.fsproj | Updates TUnit and TUnit.Assertions.FSharp package references in F# template to 1.5.37 |
| TUnit.Templates/content/TUnit.Aspire.Test/ExampleNamespace.csproj | Updates TUnit package reference in Aspire test template to 1.5.37 |
| TUnit.Templates/content/TUnit.Aspire.Starter/ExampleNamespace.TestProject/ExampleNamespace.TestProject.csproj | Updates TUnit package reference in Aspire starter template to 1.5.37 |
| TUnit.Templates/content/TUnit.AspNet/TestProject/TestProject.csproj | Updates TUnit package reference in ASP.NET template to 1.5.37 |
| TUnit.Templates/content/TUnit.AspNet.FSharp/TestProject/TestProject.fsproj | Updates TUnit and TUnit.Assertions.FSharp package references in ASP.NET F# template to 1.5.37 |
| <PackageVersion Include="Testcontainers.PostgreSql" Version="4.9.0" /> | ||
| <PackageVersion Include="Testcontainers.Redis" Version="4.9.0" /> | ||
| <PackageVersion Include="trxparser" Version="0.5.0" /> | ||
| <PackageVersion Include="TUnit.Assertions.FSharp" Version="0.75.38-PullRequest3485.0" /> |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TUnit.Assertions.FSharp package version is inconsistent with the other TUnit packages being updated in this PR. This package is still at version "0.75.38-PullRequest3485.0" while TUnit, TUnit.Core, and TUnit.Assertions are being updated to 1.5.37. According to the PR metadata, TUnit.Assertions.FSharp should also be updated to 1.5.37 to match the other packages.
| <PackageVersion Include="TUnit.Assertions.FSharp" Version="0.75.38-PullRequest3485.0" /> | |
| <PackageVersion Include="TUnit.Assertions.FSharp" Version="1.5.37" /> |
Directory.Packages.props
Outdated
| <PackageVersion Include="TUnit.Assertions" Version="1.5.35" /> | ||
| <PackageVersion Include="TUnit" Version="1.5.37" /> | ||
| <PackageVersion Include="TUnit.Core" Version="1.5.37" /> | ||
| <PackageVersion Include="TUnit.Assertions" Version="1.5.37" /> |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TUnit.Playwright package is missing from the centralized package version management, but is being updated to version 1.5.37 in the template files (e.g., TUnit.Templates/content/TUnit.Playwright/TestProject.csproj). To maintain consistency with the central package management approach used in this project, TUnit.Playwright should be added here with Version="1.5.37".
| <PackageVersion Include="TUnit.Assertions" Version="1.5.37" /> | |
| <PackageVersion Include="TUnit.Assertions" Version="1.5.37" /> | |
| <PackageVersion Include="TUnit.Playwright" Version="1.5.37" /> |
5cd55ff to
4cf33bd
Compare
PR Review: TUnit 1.5.35 → 1.5.37 UpdateOverviewThis Renovate Bot PR updates TUnit package references from version 1.5.35 to 1.5.37 across template projects and the central package management file. ✅ Positive Findings1. Consistency & Correctness
2. Scope Appropriateness
3. Release Notes Validation
This is a legitimate patch release with a bug fix, making the update low-risk. 🔍 Code Quality AssessmentFile Changes (9 files total):
All changes follow the exact same pattern: version string replacement from 🎯 Per CLAUDE.md GuidelinesRule 1 (Dual-Mode Implementation): ✅ N/A
Rule 2 (Snapshot Testing): ✅ N/A
Rule 3 (No VSTest): ✅ PASS
Rule 4 (Performance First): ✅ N/A
Rule 5 (AOT/Trimming): ✅ N/A
Code Style: ✅ N/A
🚨 Considerations & Recommendations1. Testing Recommendation # Verify templates still work after the update
dotnet new install TUnit.Templates
dotnet new tunit -n TestTemplateValidation
cd TestTemplateValidation
dotnet build
dotnet run2. Changelog Validation 3. Automerge Configuration
Automerge is appropriate for this PR, assuming CI passes. 📊 Risk AssessmentRisk Level: 🟢 LOW Justification:
✅ Final VerdictAPPROVE ✓ This PR is well-formed, follows TUnit conventions, and safely updates dependencies to incorporate a bug fix. No code quality issues, security concerns, or performance regressions expected. Recommendation: Merge after CI validation. 📋 Pre-Merge Checklist (Auto-verified)
Note: Ensure CI passes before automerge completes. |
4cf33bd to
e67b30d
Compare
PR Review: TUnit Dependency Update (1.5.35 → 1.5.37)✅ SummaryThis is a straightforward automated dependency update by Renovate Bot, bumping TUnit packages from version 1.5.35 to 1.5.37 across the codebase. 📋 Review FindingsCode Quality: ✅ EXCELLENT
Files Changed (9 files):
Packages Updated:
🔍 Technical AnalysisWhat Changed in 1.5.37:Per the release notes, version 1.5.37 includes:
This is a patch release fixing assertion chaining behavior. Test Coverage: ✅ PASS
Performance Considerations: ✅ N/A
Security Concerns: ✅ NONE
Breaking Changes: ✅ NONE
✅ Recommendation: APPROVE & MERGEThis PR is safe to merge. It's a standard Renovate Bot dependency update that:
No action required - let Renovate complete the automated merge process. |
e67b30d to
fe411fd
Compare
Pull Request ReviewThis is an automated dependency update PR from Renovate that bumps TUnit package versions from 1.5.35 to 1.5.41 across the templates and central package management. ✅ Code Quality - APPROVEDPositive Observations:
📦 Changes SummaryThe PR updates 5 TUnit packages across 9 files:
🔍 What's in 1.5.35 → 1.5.41Based on release notes, this includes:
Both are patch releases with bug fixes - safe to merge. 🎯 TUnit Guidelines CompliancePer CLAUDE.md requirements: ✅ No dual-mode changes - This is a dependency bump, not a feature implementation 🧪 Testing RecommendationsAutomated Testing:
Manual Verification (if desired): # Test template instantiation and build
dotnet new tunit -o TestTUnit
cd TestTUnit && dotnet test
cd ..
dotnet new tunit-fsharp -o TestTUnitFS
cd TestTUnitFS && dotnet test🚀 RecommendationLGTM - Approve & Merge This is a routine dependency update with:
The changes in the target versions (prevention of property getter side effects and assertion chaining fixes) are valuable improvements that should be propagated to templates. Note: Renovate has automerge enabled for this PR, so it should merge automatically once CI passes. No action required unless CI fails. |
fe411fd to
cbdd423
Compare
This PR contains the following updates:
1.5.35->1.5.421.5.35->1.5.421.5.35->1.5.421.5.35->1.5.421.5.35->1.5.42Release Notes
thomhurst/TUnit (TUnit)
v1.5.42: 1.5.42What's Changed
🏕 Changes
Full Changelog: v1.5.41...v1.5.42
v1.5.41: 1.5.41What's Changed
🏕 Changes
Full Changelog: v1.5.37...v1.5.41
v1.5.37: 1.5.37What's Changed
🏕 Changes
👒 Dependencies
Full Changelog: v1.5.35...v1.5.37
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.