Skip to content

Bash output fix to match real 'ruby embed.rb' call r? @steveklabnik #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thomas07vt
Copy link
Owner

The embed rust file that we compile prints out 'Thread finished..' messages along with a 'done!' r? @steveklabnik

The embed rust file that we compile prints out 'Thread finished..' messages along with a 'done!'
@steveklabnik
Copy link

Hey @thomas07vt

it looks like this is a PR to your own repo, is that what you intended?

Also, there are two done!s, is that actually in the real output?

@thomas07vt
Copy link
Owner Author

Yeah there should be another on the actual Rust repo.

Yep, two done!'s one from the ruby puts statement and one from the rust lib.
Ill close this pull request and we can follow up on the Rust PR.

edit.. yeah here is the PR: @steveklabnik
rust-lang#28186

@thomas07vt thomas07vt closed this Sep 3, 2015
@steveklabnik
Copy link

Cool :) let me see...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants