-
Notifications
You must be signed in to change notification settings - Fork 563
Dashboard: Migrate Various forms in contract pages from chakra to tailwind #7690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Migrate Various forms in contract pages from chakra to tailwind #7690
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes migrate several NFT-related dashboard form components from Chakra UI to a custom UI component library. This includes refactoring forms to use new form control components, updating accordion implementations, removing file upload support from properties, and adjusting error handling and validation patterns. No core business logic or transaction handling was altered. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FormComponent
participant CustomUI
participant ReactHookForm
User->>FormComponent: Interacts with form fields
FormComponent->>CustomUI: Renders FormField, FormItem, etc.
FormComponent->>ReactHookForm: Uses control for field state
ReactHookForm-->>FormComponent: Provides field values, errors
CustomUI-->>User: Displays form, error messages, buttons
User->>FormComponent: Submits form
FormComponent->>ReactHookForm: Handles submission logic
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7690 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 908 908
Lines 58177 58177
Branches 4207 4207
=======================================
Hits 32765 32765
Misses 25302 25302
Partials 110 110
🚀 New features to boost your workflow:
|
size-limit report 📦
|
4887480
to
65ba7ea
Compare
1e18e10
to
4733aff
Compare
65ba7ea
to
88d44af
Compare
4733aff
to
41b349a
Compare
41b349a
to
d10710d
Compare
Merge activity
|
…lwind (#7690) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the form components in the dashboard's NFT management system to improve structure and usability. It replaces Chakra UI components with custom UI components, enhancing consistency and maintainability. ### Detailed summary - Refactored `PropertiesFormControl` to utilize custom form components. - Removed unused imports and consolidated imports from `@chakra-ui/react`. - Updated form handling to use `FormField`, `FormItem`, and `FormDescription`. - Enhanced error handling by integrating `FormMessage` for displaying validation messages. - Replaced `Flex`, `FormControl`, and other Chakra UI components with custom equivalents. - Updated `LazyMintNftForm`, `NFTMintForm`, and `UpdateNftMetadata` forms to use new structure and components. - Improved user experience by refining button and input styles and behavior. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Migrated all NFT-related form components from Chakra UI to a custom UI library, updating form controls, buttons, accordions, and input elements. * Updated error handling and helper text display to use new form components. * Simplified and modernized form structures for minting, lazy minting, metadata updates, and property controls. * Removed file upload support and reset functionality from the properties form. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
d10710d
to
1659ae3
Compare
PR-Codex overview
This PR refactors components in the dashboard by replacing Chakra UI components with custom UI components, enhancing form handling, and improving code organization for better maintainability.
Detailed summary
properties.shared.tsx
,lazy-mint-form.tsx
,mint-form.tsx
, andupdate-metadata-form.tsx
.FormField
,FormItem
, andFormMessage
for better error management.Summary by CodeRabbit