Skip to content

Dashboard: Migrate Various forms in contract pages from chakra to tailwind #7690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jul 23, 2025


PR-Codex overview

This PR refactors components in the dashboard by replacing Chakra UI components with custom UI components, enhancing form handling, and improving code organization for better maintainability.

Detailed summary

  • Replaced Chakra UI components with custom components in properties.shared.tsx, lazy-mint-form.tsx, mint-form.tsx, and update-metadata-form.tsx.
  • Refactored form handling to use FormField, FormItem, and FormMessage for better error management.
  • Simplified the structure of forms for clarity and maintainability.
  • Updated button styles and class names for consistency across components.
  • Removed unused imports and streamlined component imports.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor
    • Migrated all NFT-related form components from Chakra UI to a custom UI library, updating form controls, buttons, accordions, and input elements.
    • Updated error handling and helper text display to use new form components.
    • Simplified and modernized form structures for minting, lazy minting, metadata updates, and property controls.
    • Removed file upload support and reset functionality from the properties form.

Copy link

changeset-bot bot commented Jul 23, 2025

⚠️ No Changeset found

Latest commit: d10710d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 6:58pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 24, 2025 6:58pm
nebula ⬜️ Skipped (Inspect) Jul 24, 2025 6:58pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 24, 2025 6:58pm
wallet-ui ⬜️ Skipped (Inspect) Jul 24, 2025 6:58pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 23, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 23, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 23, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 23, 2025 23:46 Inactive
Copy link
Contributor

coderabbitai bot commented Jul 23, 2025

Walkthrough

The changes migrate several NFT-related dashboard form components from Chakra UI to a custom UI component library. This includes refactoring forms to use new form control components, updating accordion implementations, removing file upload support from properties, and adjusting error handling and validation patterns. No core business logic or transaction handling was altered.

Changes

File(s) Change Summary
.../components/contracts/properties.shared.tsx Refactored PropertiesFormControl to use custom UI form components, removed Chakra UI, eliminated file upload and reset button logic, updated error handling, and switched from register to controlled FormField components.
.../nfts/[tokenId]/components/update-metadata-form.tsx Migrated UpdateNftMetadata to custom UI form and accordion components, replaced Chakra UI, updated form field structure, adjusted error and description handling, removed isDirty usage, and changed function export style.
.../nfts/components/lazy-mint-form.tsx Refactored LazyMintNftForm to use custom UI form and accordion components, replaced Chakra UI, integrated form fields with react-hook-form control via render props, updated error and helper text handling, and changed export to named function.
.../nfts/components/mint-form.tsx Migrated NFTMintForm to custom UI form controls and accordion, replaced Chakra UI, updated form integration with react-hook-form, revised error and description handling, updated button props, and changed export to named function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FormComponent
    participant CustomUI
    participant ReactHookForm

    User->>FormComponent: Interacts with form fields
    FormComponent->>CustomUI: Renders FormField, FormItem, etc.
    FormComponent->>ReactHookForm: Uses control for field state
    ReactHookForm-->>FormComponent: Provides field values, errors
    CustomUI-->>User: Displays form, error messages, buttons
    User->>FormComponent: Submits form
    FormComponent->>ReactHookForm: Handles submission logic
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Moderate complexity due to comprehensive UI refactor across multiple interrelated form components.
  • Requires careful review to ensure form logic, validation, and error handling remain correct after migration.
  • No core business logic changes, but significant structural and pattern updates.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d10710d and 1659ae3.

📒 Files selected for processing (4)
  • apps/dashboard/src/@/components/contracts/properties.shared.tsx (4 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/update-metadata-form.tsx (4 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/lazy-mint-form.tsx (6 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/mint-form.tsx (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • apps/dashboard/src/@/components/contracts/properties.shared.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/mint-form.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/lazy-mint-form.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/update-metadata-form.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Lint Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 07-24-dashboard_migrate_various_forms_from_chakra_to_tailwind_css

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 23, 2025
@MananTank MananTank marked this pull request as ready for review July 23, 2025 23:46
@MananTank MananTank requested review from a team as code owners July 23, 2025 23:46
Copy link
Member Author

MananTank commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title Dashboard: Migrate Various forms from chakra to tailwind CSS Dashboard: Migrate Various forms in contract pages from chakra to tailwind CSS Jul 23, 2025
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.31%. Comparing base (88d44af) to head (1659ae3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7690   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         908      908           
  Lines       58177    58177           
  Branches     4207     4207           
=======================================
  Hits        32765    32765           
  Misses      25302    25302           
  Partials      110      110           
Flag Coverage Δ
packages 56.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.33 KB (0%) 1.3 s (0%) 412 ms (+90.09% 🔺) 1.7 s
thirdweb (cjs) 353.15 KB (0%) 7.1 s (0%) 1.6 s (+0.63% 🔺) 8.7 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 156 ms (+798.85% 🔺) 270 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 77 ms (+1572.27% 🔺) 87 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 85 ms (+201.62% 🔺) 469 ms

@MananTank MananTank changed the title Dashboard: Migrate Various forms in contract pages from chakra to tailwind CSS Dashboard: Migrate Various forms in contract pages from chakra to tailwind Jul 23, 2025
@graphite-app graphite-app bot changed the base branch from 07-24-dashboard_migrate_batch_upload_nfts_to_tailwind_ui_improvements to graphite-base/7690 July 24, 2025 02:54
@graphite-app graphite-app bot force-pushed the graphite-base/7690 branch from 65ba7ea to 88d44af Compare July 24, 2025 18:31
@graphite-app graphite-app bot force-pushed the 07-24-dashboard_migrate_various_forms_from_chakra_to_tailwind_css branch from 4733aff to 41b349a Compare July 24, 2025 18:31
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 24, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 24, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 24, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 24, 2025 18:32 Inactive
@graphite-app graphite-app bot changed the base branch from graphite-base/7690 to main July 24, 2025 18:32
@graphite-app graphite-app bot force-pushed the 07-24-dashboard_migrate_various_forms_from_chakra_to_tailwind_css branch from 41b349a to d10710d Compare July 24, 2025 18:32
@vercel vercel bot temporarily deployed to Preview – nebula July 24, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 24, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 24, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 24, 2025 18:32 Inactive
Copy link
Contributor

graphite-app bot commented Jul 24, 2025

Merge activity

…lwind (#7690)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the form components in the dashboard's NFT management system to improve structure and usability. It replaces Chakra UI components with custom UI components, enhancing consistency and maintainability.

### Detailed summary
- Refactored `PropertiesFormControl` to utilize custom form components.
- Removed unused imports and consolidated imports from `@chakra-ui/react`.
- Updated form handling to use `FormField`, `FormItem`, and `FormDescription`.
- Enhanced error handling by integrating `FormMessage` for displaying validation messages.
- Replaced `Flex`, `FormControl`, and other Chakra UI components with custom equivalents.
- Updated `LazyMintNftForm`, `NFTMintForm`, and `UpdateNftMetadata` forms to use new structure and components.
- Improved user experience by refining button and input styles and behavior.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Refactor**
  * Migrated all NFT-related form components from Chakra UI to a custom UI library, updating form controls, buttons, accordions, and input elements.
  * Updated error handling and helper text display to use new form components.
  * Simplified and modernized form structures for minting, lazy minting, metadata updates, and property controls.
  * Removed file upload support and reset functionality from the properties form.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 07-24-dashboard_migrate_various_forms_from_chakra_to_tailwind_css branch from d10710d to 1659ae3 Compare July 24, 2025 18:49
@graphite-app graphite-app bot merged commit 1659ae3 into main Jul 24, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-24-dashboard_migrate_various_forms_from_chakra_to_tailwind_css branch July 24, 2025 18:58
@vercel vercel bot temporarily deployed to Production – docs-v2 July 24, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui July 24, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 24, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Production – nebula July 24, 2025 18:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants