-
Notifications
You must be signed in to change notification settings - Fork 579
[SDK] Respect fee payer in token payment selection quotes #7556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Respect fee payer in token payment selection quotes #7556
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 8aa3705 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe changes introduce a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BridgeOrchestrator
participant PaymentSelection
participant TokenSelection
participant PaymentMethodTokenRow
participant useBridgeQuote
User->>BridgeOrchestrator: Initiates payment/bridge flow
BridgeOrchestrator->>PaymentSelection: Renders with feePayer (if direct_payment)
PaymentSelection->>TokenSelection: Passes feePayer prop
TokenSelection->>PaymentMethodTokenRow: Passes feePayer prop
PaymentMethodTokenRow->>useBridgeQuote: Calls with feePayer
useBridgeQuote-->>PaymentMethodTokenRow: Returns quote respecting feePayer
PaymentMethodTokenRow-->>TokenSelection: Displays token row with correct fee logic
TokenSelection-->>PaymentSelection: Token selected
PaymentSelection-->>BridgeOrchestrator: Payment method selected
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were found. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🧰 Additional context used📓 Path-based instructions (1)`**/*.{ts,tsx}`: Write idiomatic TypeScript with explicit function declarations ...
📄 Source: CodeRabbit Inference Engine (CLAUDE.md) List of files the instruction was applied to:
🧠 Learnings (6)📓 Common learnings
.changeset/good-papers-give.md (3)
packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx (6)
packages/thirdweb/src/react/web/ui/Bridge/payment-selection/PaymentSelection.tsx (8)
packages/thirdweb/src/react/web/ui/Bridge/payment-selection/TokenSelection.tsx (7)
packages/thirdweb/src/react/core/hooks/useBridgeQuote.ts (8)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (11)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Fixes #7518
Summary by CodeRabbit
New Features
Bug Fixes