Skip to content

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jul 1, 2025


PR-Codex overview

This PR focuses on refactoring the routes-table, routelist-card, and routelist-row components to improve code readability and structure by replacing traditional HTML table elements with custom components, enhancing the UI with better styling and functionality.

Detailed summary

  • Replaced <TableContainer> and related elements with custom components in routes-table.tsx.
  • Introduced TokenName and TokenInfo components in routelist-card.tsx and routelist-row.tsx for better handling of token display logic.
  • Removed legacy table structure in routelist-card.tsx, replacing it with flexbox for layout.
  • Updated styles for improved UI consistency across components.
  • Added imports for ExternalLinkIcon and Link to enhance token linking functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added clickable links to ERC20 token pages for improved navigation and clarity in token displays.
    • Introduced new helper components for consistent token information display.
  • Refactor

    • Updated token display layouts to use flexbox for better alignment and readability.
    • Consolidated repeated token rendering logic into reusable components.
  • Style

    • Simplified and removed custom styling from tables and cards for a cleaner appearance.

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 8:23pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 1, 2025 8:23pm
nebula ⬜️ Skipped (Inspect) Jul 1, 2025 8:23pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 1, 2025 8:23pm
wallet-ui ⬜️ Skipped (Inspect) Jul 1, 2025 8:23pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 1, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 1, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 1, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 1, 2025 17:02 Inactive
Copy link

linear bot commented Jul 1, 2025

Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: 1305527

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 1, 2025

"""

Walkthrough

The code refactors how token information is displayed in both card and table formats on the routes page. It introduces reusable components (TokenName and TokenInfo) to encapsulate token display logic, including conditional linking to the asset page for ERC20 tokens. Visual styling classes are simplified or removed from the table layout.

Changes

File(s) Change Summary
.../routes/components/server/routelist-card.tsx Refactored token display to use new TokenName component; added conditional linking for ERC20 tokens; updated imports
.../routes/components/server/routelist-row.tsx Refactored token info display to new TokenInfo component; added conditional linking for ERC20 tokens; updated imports
.../routes/components/server/routes-table.tsx Removed most styling classes from table container and headers; no logic changes

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RouteListCard
    participant TokenName
    participant RouteListRow
    participant TokenInfo

    User->>RouteListCard: Render card with token info
    RouteListCard->>TokenName: Render token (address, name, chainMetadata)
    TokenName-->>RouteListCard: Rendered token (with/without link)

    User->>RouteListRow: Render table row with token info
    RouteListRow->>TokenInfo: Render token (address, symbol, chainMetadata, iconUri)
    TokenInfo-->>RouteListRow: Rendered token (with/without link)
Loading

Assessment against linked issues

Objective (Issue) Addressed Explanation
Add link to asset page for ERC20 tokens in routes page (TOOL-4900)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation

Suggested reviewers

  • jnsdls
    """

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60e6544 and 1305527.

📒 Files selected for processing (3)
  • apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/components/server/routelist-card.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/components/server/routelist-row.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/components/server/routes-table.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/components/server/routes-table.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/components/server/routelist-card.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/components/server/routelist-row.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 1, 2025
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (b882ad7) to head (1305527).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7493   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         949      949           
  Lines       64148    64148           
  Branches     4229     4229           
=======================================
  Hits        33311    33311           
  Misses      30731    30731           
  Partials      106      106           
Flag Coverage Δ
packages 51.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank marked this pull request as ready for review July 1, 2025 17:06
@MananTank MananTank requested review from a team as code owners July 1, 2025 17:06
@MananTank MananTank changed the title [TOOL-4900] Dashboard: Add ERC20 token page links in routes page [TOOL-4900] Dashboard: Add ERC20 token page links in /routes Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 239 ms (+105.42% 🔺) 1.6 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 985 ms (+6.58% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 104 ms (+1479.55% 🔺) 218 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 39 ms (+1050.45% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 135 ms (+568.8% 🔺) 527 ms

Copy link
Contributor

graphite-app bot commented Jul 1, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring components in the `routes-table`, `routelist-card`, and `routelist-row` files to improve structure and readability, while introducing new components like `TokenName` and `TokenInfo` for better token representation.

### Detailed summary
- Replaced `TableContainer` with a simpler structure in `routes-table.tsx`.
- Changed table header structure to improve readability.
- Refactored `routelist-card.tsx` to use `TokenName` for token display.
- Introduced `TokenInfo` component in `routelist-row.tsx` for consistent token representation.
- Removed inline token display logic in favor of new components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Added clickable links to ERC20 token pages for improved navigation and clarity in token displays.
  * Introduced new helper components for consistent token information display.

* **Refactor**
  * Updated token display layouts to use flexbox for better alignment and readability.
  * Consolidated repeated token rendering logic into reusable components.

* **Style**
  * Simplified and removed custom styling from tables and cards for a cleaner appearance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 07-01-_tool-4900_dashboard_add_erc20_token_page_links_in_routes_page branch from 60e6544 to 1305527 Compare July 1, 2025 20:15
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 1, 2025 20:16 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 1, 2025 20:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 1, 2025 20:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 1, 2025 20:16 Inactive
@graphite-app graphite-app bot merged commit 1305527 into main Jul 1, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-01-_tool-4900_dashboard_add_erc20_token_page_links_in_routes_page branch July 1, 2025 20:24
@vercel vercel bot temporarily deployed to Production – nebula July 1, 2025 20:24 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 1, 2025 20:24 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui July 1, 2025 20:24 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 July 1, 2025 20:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants